Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extra_unused_lifetimes add FP test case emitting from derived attributes. #9043

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

dswij
Copy link
Member

@dswij dswij commented Jun 24, 2022

Add test to cover for #9014 which is fixed in #9037.

changelog: [extra_unused_lifetimes] Add FP test case emitting from derived attributes.


Seeing the FP from the test:

$ git revert -m 1 1d1ae10876d3eaa5c982dd3daa083b7c2fc363b9
$ TESTNAME=extra_unused_lifetime cargo uitest

This commit adds test for a `extra_unused_lifetimes` false positive from derive (rust-lang#9014).

The fix for the FP is introduced in rust-lang#9037.
@rust-highfive
Copy link

r? @Manishearth

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 24, 2022
@dswij
Copy link
Member Author

dswij commented Jun 29, 2022

Thanks for the review!

@bors r=Manishearth

@bors
Copy link
Contributor

bors commented Jun 29, 2022

📌 Commit a8f6824 has been approved by Manishearth

@bors
Copy link
Contributor

bors commented Jun 29, 2022

⌛ Testing commit a8f6824 with merge 70f1d0d...

@bors
Copy link
Contributor

bors commented Jun 29, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 70f1d0d to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants