Skip to content

extra_unused_lifetimes add FP test case emitting from derived attributes. #9043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions tests/ui/auxiliary/proc_macro_derive.rs
Original file line number Diff line number Diff line change
@@ -72,3 +72,17 @@ pub fn mini_macro(_: TokenStream) -> TokenStream {
}
)
}

#[proc_macro_derive(ExtraLifetimeDerive)]
#[allow(unused)]
pub fn extra_lifetime(_input: TokenStream) -> TokenStream {
quote!(
pub struct ExtraLifetime;

impl<'b> ExtraLifetime {
pub fn something<'c>() -> Self {
Self
}
}
)
}
12 changes: 12 additions & 0 deletions tests/ui/extra_unused_lifetimes.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// aux-build:proc_macro_derive.rs

#![allow(
unused,
dead_code,
@@ -7,6 +9,9 @@
)]
#![warn(clippy::extra_unused_lifetimes)]

#[macro_use]
extern crate proc_macro_derive;

fn empty() {}

fn used_lt<'a>(x: &'a u8) {}
@@ -114,4 +119,11 @@ mod second_case {
}
}

// Should not lint
#[derive(ExtraLifetimeDerive)]
struct Human<'a> {
pub bones: i32,
pub name: &'a str,
}

fn main() {}
12 changes: 6 additions & 6 deletions tests/ui/extra_unused_lifetimes.stderr
Original file line number Diff line number Diff line change
@@ -1,37 +1,37 @@
error: this lifetime isn't used in the function definition
--> $DIR/extra_unused_lifetimes.rs:14:14
--> $DIR/extra_unused_lifetimes.rs:19:14
|
LL | fn unused_lt<'a>(x: u8) {}
| ^^
|
= note: `-D clippy::extra-unused-lifetimes` implied by `-D warnings`

error: this lifetime isn't used in the function definition
--> $DIR/extra_unused_lifetimes.rs:41:10
--> $DIR/extra_unused_lifetimes.rs:46:10
|
LL | fn x<'a>(&self) {}
| ^^

error: this lifetime isn't used in the function definition
--> $DIR/extra_unused_lifetimes.rs:67:22
--> $DIR/extra_unused_lifetimes.rs:72:22
|
LL | fn unused_lt<'a>(x: u8) {}
| ^^

error: this lifetime isn't used in the impl
--> $DIR/extra_unused_lifetimes.rs:78:10
--> $DIR/extra_unused_lifetimes.rs:83:10
|
LL | impl<'a> std::ops::AddAssign<&Scalar> for &mut Scalar {
| ^^

error: this lifetime isn't used in the impl
--> $DIR/extra_unused_lifetimes.rs:84:10
--> $DIR/extra_unused_lifetimes.rs:89:10
|
LL | impl<'b> Scalar {
| ^^

error: this lifetime isn't used in the function definition
--> $DIR/extra_unused_lifetimes.rs:85:26
--> $DIR/extra_unused_lifetimes.rs:90:26
|
LL | pub fn something<'c>() -> Self {
| ^^