Skip to content

Commit

Permalink
Auto merge of #112646 - vn971:document-thread-names-for-sgx-target, r…
Browse files Browse the repository at this point in the history
…=m-ou-se

Document thread names for SGX compilation target

`@raoulstrackx` `@Mkaynov` `@jethrogb`
  • Loading branch information
bors committed Jul 25, 2023
2 parents c026d6a + 748e2c6 commit ff8fe76
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion library/std/src/sys/sgx/thread.rs
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,16 @@ impl Thread {
rtassert!(wait_error.kind() == io::ErrorKind::WouldBlock);
}

/// SGX should protect in-enclave data from the outside (attacker),
/// so there should be no data leakage to the OS,
/// and therefore also no 1-1 mapping between SGX thread names and OS thread names.
///
/// This is why the method is intentionally No-Op.
pub fn set_name(_name: &CStr) {
// FIXME: could store this pointer in TLS somewhere
// Note that the internally visible SGX thread name is already provided
// by the platform-agnostic (target-agnostic) Rust thread code.
// This can be observed in the [`std::thread::tests::test_named_thread`] test,
// which succeeds as-is with the SGX target.
}

pub fn sleep(dur: Duration) {
Expand Down

0 comments on commit ff8fe76

Please sign in to comment.