Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document thread names for SGX compilation target #112646

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Document thread names for SGX compilation target #112646

merged 1 commit into from
Jul 25, 2023

Conversation

vn971
Copy link
Contributor

@vn971 vn971 commented Jun 15, 2023 •
edited
Loading

@rustbot
Copy link
Collaborator

rustbot commented Jun 15, 2023

r? @joshtriplett

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 15, 2023
@vn971
Copy link
Contributor Author

vn971 commented Jun 15, 2023

r? @raoulstrackx

@rustbot
Copy link
Collaborator

rustbot commented Jun 15, 2023

Failed to set assignee to raoulstrackx: invalid assignee

Note: Only org members, users with write permissions, or people who have commented on the PR may be assigned.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@vn971 vn971 mentioned this pull request Jun 15, 2023
Closed
@vn971 vn971 force-pushed the document-thread-names-for-sgx-target branch from ec5f9d1 to 4d20999 Compare June 15, 2023 08:12
raoulstrackx
raoulstrackx suggested changes Jun 15, 2023
View reviewed changes
library/std/src/sys/sgx/thread.rs Outdated Show resolved Hide resolved
@vn971 vn971 force-pushed the document-thread-names-for-sgx-target branch 2 times, most recently from c6387e7 to 324c884 Compare June 16, 2023 08:58
@raoulstrackx
Copy link
Contributor

Looks good to me!

@vn971 vn971 force-pushed the document-thread-names-for-sgx-target branch from 324c884 to 2955284 Compare June 19, 2023 06:22
@vn971 vn971 force-pushed the document-thread-names-for-sgx-target branch from 2955284 to 748e2c6 Compare June 19, 2023 08:25
@vn971
Copy link
Contributor Author

vn971 commented Jun 19, 2023

@joshtriplett Could you please review? There's now a positive review from 2 maintainers of the SGX target in Rust. Would be nice to merge it.

@vn971
Copy link
Contributor Author

vn971 commented Jun 20, 2023

r? @raoulstrackx

@rustbot rustbot assigned raoulstrackx and unassigned joshtriplett Jun 20, 2023
@raoulstrackx
Copy link
Contributor

raoulstrackx commented Jul 5, 2023 •
edited
Loading

@bors r+

@raoulstrackx
Copy link
Contributor

@joshtriplett could you take a look please?

@raoulstrackx
Copy link
Contributor

bors r+

@vn971
Copy link
Contributor Author

vn971 commented Jul 21, 2023

r? @joshtriplett

@rustbot rustbot assigned joshtriplett and unassigned raoulstrackx Jul 21, 2023
@m-ou-se
Copy link
Member

m-ou-se commented Jul 25, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 25, 2023

📌 Commit 748e2c6 has been approved by m-ou-se

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 25, 2023
@bors
Copy link
Contributor

bors commented Jul 25, 2023

⌛ Testing commit 748e2c6 with merge ff8fe76...

@bors
Copy link
Contributor

bors commented Jul 25, 2023

☀️ Test successful - checks-actions
Approved by: m-ou-se
Pushing ff8fe76 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 25, 2023
@bors bors merged commit ff8fe76 into rust-lang:master Jul 25, 2023
@rustbot rustbot added this to the 1.73.0 milestone Jul 25, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ff8fe76): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.4% [3.4%, 3.4%] 1
Regressions ❌
(secondary)		 1.6% [1.6%, 1.6%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -3.7% [-3.7%, -3.7%] 1
All ❌✅ (primary) 3.4% [3.4%, 3.4%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 649.334s -> 651.831s (0.38%)

@workingjubilee workingjubilee added the O-SGX Target: SGX label Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jethrogb jethrogb jethrogb left review comments

@raoulstrackx raoulstrackx raoulstrackx approved these changes

Assignees

@joshtriplett joshtriplett

Labels
merged-by-bors This PR was explicitly merged by bors. O-SGX Target: SGX S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.
10 participants
@vn971 @rustbot @rust-log-analyzer @raoulstrackx @m-ou-se @bors @rust-timer @jethrogb @joshtriplett @workingjubilee