Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug-info test failure on windows #10474

Closed
klutzy opened this issue Nov 14, 2013 · 10 comments
Closed

debug-info test failure on windows #10474

klutzy opened this issue Nov 14, 2013 · 10 comments
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.)

Comments

@klutzy
Copy link
Contributor

klutzy commented Nov 14, 2013

failures:
    [debug-info] debug-info/by-value-self-argument-in-trait-impl.rs
    [debug-info] debug-info/var-captured-in-nested-closure.rs

by-value-self-argument-in-trait-impl test fails to print the first self.

(gdb) print self
$1 = <optimized out>

var-captured-in-nested-closure test fails to print closure_local.

(gdb) print closure_local
No symbol "closure_local" in current context

cc #10452

@jdm
Copy link
Contributor

jdm commented Nov 14, 2013

We should check whether we're disabling all optimization when building the debuginfo tests.

@klutzy
Copy link
Contributor Author

klutzy commented Nov 14, 2013

I manually built the first one: rustc.exe -Z extra-debug-info --opt-level=0 <test>.rs but gdb still prints $1 = <optimized out>. Does it indicate that something is missing?

@jdm
Copy link
Contributor

jdm commented Nov 14, 2013

I... don't really know what that means.

@alexcrichton
Copy link
Member

We pump llvm through an extra g++ pass on windows, right? Is it possible that there's some optimizations accidentally getting tacked on at that stage?

@michaelwoerister
Copy link
Member

by-value self is not really supported yet (see "Known issues" http://michaelwoerister.github.io/2013/09/27/what-you-call-the-present.html). I'm surprised that the first test case passes on other platforms.

@michaelwoerister
Copy link
Member

I opened a separate issue about by-value-self: #10549

@alexcrichton
Copy link
Member

Now that #10549 is closed, it sounds like this just needs to be verified to be working on today's compiler

@klutzy
Copy link
Contributor Author

klutzy commented Apr 1, 2014

confirmed that both tests work with nightly. yay!

@alexcrichton
Copy link
Member

Closing, the tests are checked in, and don't have ignore directives for windows. Once we start running debuginfo tests on windows, these should hopefully "just work".

@alexcrichton
Copy link
Member

Oops, looks like debug-info/var-captured-in-nested-closure.rs is still xfail'd for windows,

@alexcrichton alexcrichton reopened this Apr 1, 2014
klutzy added a commit to klutzy/rust that referenced this issue Apr 3, 2014
flip1995 pushed a commit to flip1995/rust that referenced this issue Mar 24, 2023
Don't lint `manual_clamp` in const contexts.

fixes rust-lang#10474

Probably worth including in the sync.
r? `@flip1995`

changelog: [`manual_clamp`]: Don't lint in const contexts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.)
Projects
None yet
Development

No branches or pull requests

4 participants