Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/test/ui/traits/predicate_can_apply-hang.rs is failing spuriously #104957

Closed
jyn514 opened this issue Nov 26, 2022 · 2 comments · Fixed by #104959
Closed

src/test/ui/traits/predicate_can_apply-hang.rs is failing spuriously #104957

jyn514 opened this issue Nov 26, 2022 · 2 comments · Fixed by #104959

Comments

@jyn514
Copy link
Member

jyn514 commented Nov 26, 2022

First introduced in #104269, cc @compiler-errors

---- [ui]  stdout ----

error: Error: expected failure status (Some(1)) but received status None.
status: signal: 6 (SIGABRT) (core dumped)
Some tests failed in compiletest suite=ui mode=ui host=i686-unknown-linux-gnu target=i686-unknown-linux-gnu
command: "/checkout/obj/build/i686-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/traits/predicate_can_apply-hang.rs" "-Zthreads=1" "--target=i686-unknown-linux-gnu" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/i686-unknown-linux-gnu/test/ui/traits/predicate_can_apply-hang" "-A" "unused" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/i686-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/test/ui/traits/predicate_can_apply-hang/auxiliary"
stdout: none
--- stderr -------------------------------
memory allocation of 713031696 bytes failed
------------------------------------------

Originally posted by @jyn514 in #104950 (comment)

@compiler-errors
Copy link
Member

lol, the irony

@compiler-errors
Copy link
Member

I think I'll just remove the test. It was there to make sure we don't break it in the future with overflow refactoring, but it seems like overflow controls doesn't even work consistently currently.

cc: @lcnr who had asked for the test to be added

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Nov 28, 2022
Revert rust-lang#104269 (to avoid spurious hang/test failure in CI)

Causes hangs/memory overflows in the test suite apparently 😢

Reopens rust-lang#104225
Fixes rust-lang#104957
r? `@lcnr`
@bors bors closed this as completed in e674b34 Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants