Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add fatal overflow test" #104958

Closed
wants to merge 1 commit into from
Closed

Revert "Add fatal overflow test" #104958

wants to merge 1 commit into from
+0 −41

Conversation

compiler-errors
Copy link
Member

This reverts commit 9decfff.

Fixes #104957

r? @jyn514

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 26, 2022
@compiler-errors
Copy link
Member Author

I'll file a bug for the spurious hang investigation. I think it should be separate from #104957, though I guess we could reuse that issue.

@jyn514
Copy link
Member

jyn514 commented Nov 26, 2022

r? @lcnr

@rustbot rustbot assigned lcnr and unassigned jyn514 Nov 26, 2022
@jyn514
Copy link
Member

jyn514 commented Nov 26, 2022 •
edited
Loading

Note src/test/ui/typeck/hang-in-overflow.rs was also failing, so if you remove one you should probably remove the other.

@compiler-errors
Copy link
Member Author

In that case, imma just revert the whole PR.

@compiler-errors compiler-errors deleted the remove-test branch August 11, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

src/test/ui/traits/predicate_can_apply-hang.rs is failing spuriously
4 participants
@compiler-errors @jyn514 @lcnr @rustbot