Skip to content

Rename tests/ui/unique to box #109878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jyn514 opened this issue Apr 3, 2023 · 3 comments · Fixed by #110000
Closed

Rename tests/ui/unique to box #109878

jyn514 opened this issue Apr 3, 2023 · 3 comments · Fixed by #110000
Assignees
@reez12g
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@jyn514
Copy link
Member

jyn514 commented Apr 3, 2023 •
edited by rustbot
Loading

https://github.com/rust-lang/rust/tree/fe0b0428b89802f02a050eab72373b75709d0bce/tests/ui/unique all seem to be testing std::boxed::Box. It hasn't been called unique in many years, and that's now ambiguous with ptr::Unqiue. We should rename the test suite for clarity.
@jyn514 jyn514 added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. C-cleanup Category: PRs that clean code up or issues documenting cleanup. A-testsuite Area: The testsuite used to check the correctness of rustc labels Apr 3, 2023
@reez12g
Copy link
Contributor

reez12g commented Apr 3, 2023

@rustbot claim

@Noratrieb
Copy link
Member

Noratrieb commented Apr 3, 2023 •
edited
Loading

Most of these should be unit tests in library/alloc, not UI tests. Although given the amount of compiler magic behind it it my make sense to keep them as UI tests.

@jyn514
Copy link
Member Author

jyn514 commented Apr 3, 2023

No objection to that, but renaming the directory doesn't make it any harder to switch them to unit tests in the future.

@Noratrieb Noratrieb added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 5, 2023
@reez12g reez12g mentioned this issue Apr 6, 2023
Merged
@bors bors closed this as completed in 90b5597 Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reez12g reez12g

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename tests/ui/unique to tests/ui/box/unit reez12g/rust
3 participants
@jyn514 @reez12g @Noratrieb