Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename tests/ui/unique to tests/ui/box/unit #110000

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Rename tests/ui/unique to tests/ui/box/unit #110000

merged 1 commit into from
Apr 12, 2023

Conversation

reez12g
Copy link
Contributor

@reez12g reez12g commented Apr 6, 2023

fixes #109878

Since tests/ui/box already exists, I have temporarily named it boxed-box, but if another name sounds better, please let me know.

@rustbot
Copy link
Collaborator

rustbot commented Apr 6, 2023

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 6, 2023
@reez12g
Copy link
Contributor Author

reez12g commented Apr 6, 2023

r? @jyn514

@rustbot rustbot assigned jyn514 and unassigned jackh726 Apr 6, 2023
@jyn514
Copy link
Member

jyn514 commented Apr 6, 2023

I don't have time for reviews, please don't assign me.

r? @jackh726

@rustbot rustbot assigned jackh726 and unassigned jyn514 Apr 6, 2023
@Noratrieb
Copy link
Member

What's inside tests/UI/box? Can it just be merged?

@jackh726
Copy link
Member

jackh726 commented Apr 9, 2023

I think putting these under tests/ui/box/unit would be better. (Should go through and make sure all of these would be eligble as unit tests for Box)

@jackh726 jackh726 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2023
@reez12g reez12g changed the title Rename tests/ui/unique to tests/ui/boxed-box Rename tests/ui/unique to tests/ui/box/unit Apr 11, 2023
@reez12g
Copy link
Contributor Author

reez12g commented Apr 11, 2023

Moved to tests/ui/box/unit

@jackh726
I've gone through these tests and checked that they are related to Box.

@jackh726
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 12, 2023

📌 Commit d5339be has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 12, 2023
@compiler-errors compiler-errors mentioned this pull request Apr 12, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 12, 2023
@bors
Auto merge of rust-lang#110214 - compiler-errors:rollup-mkig4t6, r=co…
0d7ed3b 
…mpiler-errors

Rollup of 10 pull requests

Successful merges:

 - rust-lang#96971 (Initial support for loongarch64-unknown-linux-gnu)
 - rust-lang#109894 (Remove Errors section from var_os docs)
 - rust-lang#110000 (Rename tests/ui/unique to tests/ui/box/unit)
 - rust-lang#110018 (Pass host linker to compiletest.)
 - rust-lang#110104 ( Reword the docstring in todo! macro definition, fixing a typo)
 - rust-lang#110113 (Fix `x test ui --target foo` when download-rustc is enabled)
 - rust-lang#110126 (Support safe transmute in new solver)
 - rust-lang#110155 (Fix typos in librustdoc, tools and config files)
 - rust-lang#110162 (rustdoc: remove redundant expandSection code from main.js)
 - rust-lang#110173 (kmc-solid: Implement `Socket::read_buf`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 90b5597 into rust-lang:master Apr 12, 2023
@rustbot rustbot added this to the 1.70.0 milestone Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jackh726 jackh726

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.

Rename tests/ui/unique to box
6 participants
@reez12g @rustbot @jyn514 @Noratrieb @jackh726 @bors