rustdoc: remove redundant expandSection code from main.js #110162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This functionality is already tested in `hash-item-expansion.goml`, and was implemented twice: * First, in code that ran at load time and at hash change: 917cdd2 * Later, the hash change event handler was itself run at load time, and the code handling both cases diverged in implementation, though their behavior still matches pretty well: f66a331
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
|
Thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Apr 11, 2023
…, r=GuillaumeGomez rustdoc: remove redundant expandSection code from main.js This functionality is already tested in `hash-item-expansion.goml`, and was implemented twice: * First, in code that ran at load time and at hash change: 917cdd2 * Later, the hash change event handler was itself run at load time, and the code handling both cases diverged in implementation, though their behavior still matches pretty well: f66a331
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 12, 2023
…mpiler-errors Rollup of 10 pull requests Successful merges: - rust-lang#96971 (Initial support for loongarch64-unknown-linux-gnu) - rust-lang#109894 (Remove Errors section from var_os docs) - rust-lang#110000 (Rename tests/ui/unique to tests/ui/box/unit) - rust-lang#110018 (Pass host linker to compiletest.) - rust-lang#110104 ( Reword the docstring in todo! macro definition, fixing a typo) - rust-lang#110113 (Fix `x test ui --target foo` when download-rustc is enabled) - rust-lang#110126 (Support safe transmute in new solver) - rust-lang#110155 (Fix typos in librustdoc, tools and config files) - rust-lang#110162 (rustdoc: remove redundant expandSection code from main.js) - rust-lang#110173 (kmc-solid: Implement `Socket::read_buf`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality is already tested in
hash-item-expansion.goml, and was implemented twice:First, in code that ran at load time and at hash change: 917cdd2
Later, the hash change event handler was itself run at load time, and the code handling both cases diverged in implementation, though their behavior still matches pretty well: f66a331