Update Wake example to use pin! macro instead of Box::pin
#109965
Assignees
Labels
A-docs
Area: documentation for any part of the project, including the compiler, standard library, and tools
E-easy
Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
T-libs-api
Relevant to the library API team, which will review and decide on the PR/issue.
Comments
yoshuawuyts
added
the
A-docs
aDotInTheVoid
added
the
E-easy
|
@rustbot claim |
Noratrieb
added
the
T-libs-api
|
hey can u help me from where i can fix this |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Apr 9, 2023
Updating Wake example to use new 'pin!' macro Updating the example for the Wake trait to use `pin!` macro instead of `Box::pin`. rust-lang#109965
|
Can u tell me how u solve this? |
|
@AnuragNishad12 I have already solved this one and it is in the process of being reviewed for merging. If you wish to solve an issue, you need to pick one that has not been assigned yet. Try looking at this: https://github.com/rust-lang/rust/issues?q=is%3Aissue+is%3Aopen+label%3AE-easy+no%3Aassignee |
|
hey @madsravn im new to open source, i want to grow in this field . |
|
@AnuragNishad12 I am pretty new to this project myself, but please reach out if you have any starter-questions and then I might be able to help you out. There is a chat on https://rust-lang.zulipchat.com/ - I am just "Mads Ravn" in there. |
|
Thanks |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Apr 25, 2023
…lacrum Updating Wake example to use new 'pin!' macro Closes: rust-lang#109965 I have already had this reviewed and approved here: rust-lang#110026 . But because I had some git issues and chose the "nuke it" option as my solution it didn't get merged. I nuked it too quickly. I am sorry for trouble of reviewing twice.
thomcc
pushed a commit
to tcdi/postgrestd
that referenced
this issue
Jul 18, 2023
Updating Wake example to use new 'pin!' macro Closes: rust-lang/rust#109965 I have already had this reviewed and approved here: rust-lang/rust#110026 . But because I had some git issues and chose the "nuke it" option as my solution it didn't get merged. I nuked it too quickly. I am sorry for trouble of reviewing twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Location
https://doc.rust-lang.org/std/task/trait.Wake.html#examples
Summary
The
Wakeexample currently usesBox::pin, but now that thepin!macro has been stabilized in Rust 1.68, it should probably use that instead. This should be an easy contribution for someone who wants to land a first contribution.The text was updated successfully, but these errors were encountered: