Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiler-rt dependencies are not set up properly #12268

Closed
lilyball opened this issue Feb 14, 2014 · 3 comments
Closed

compiler-rt dependencies are not set up properly #12268

lilyball opened this issue Feb 14, 2014 · 3 comments

Comments

@lilyball
Copy link
Contributor

Running make -j4 often fails with

error: linking with `cc` failed: exit code: 1
note: cc arguments: [...]
note: ld: library not found for -lcompiler-rt

when trying to compile rustc. A subsequent make will typically work. I assume this is a dependency issue with parallel building.
@alexcrichton
Copy link
Member

This will be closed by #12263

@alexcrichton alexcrichton mentioned this issue Feb 14, 2014
Closed
@lilyball
Copy link
Contributor Author

Oh great, I hadn't seen that PR yet. Awesome.

@reem
Copy link
Contributor

reem commented Dec 15, 2014

Triage: fixed through #12263, which landed.

flip1995 pushed a commit to flip1995/rust that referenced this issue Apr 18, 2024
@mira-eanda
Fix: rust-lang#12268: Correct parentheses for needless_borrow suggestion
38b8056 
Clippy no longer adds unnecessary parentheses in suggestion when the expression is a part of a tuple.
flip1995 pushed a commit to flip1995/rust that referenced this issue Apr 18, 2024
@bors
Auto merge of rust-lang#12630 - mira-eanda:master, r=Manishearth
1b6561f 
Correct parentheses for [`needless_borrow`] suggestion

This fixes rust-lang#12268

Clippy no longer adds unnecessary parentheses in suggestions when the expression is part of a tuple.

---

changelog: Fix [`needless_borrow`] unnecessary parentheses in suggestion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add MKFILE_DEPS to compiler-rt target alexcrichton/rust
3 participants
@lilyball @alexcrichton @reem