Add MKFILE_DEPS to compiler-rt target #12263
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when you run `make -jN` it's likely that you'll remove compiler-rt and then it won't get cp'd back into the right place. I believe the reason for this is that the compiler-rt library target never got updated so make decided it never needed to copy the files back into place. The files were all there at the beginning of `make`, but then we may clean out the stage0 versions if we unzip the snapshot again.
|
LGTM |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
…ykril feat: hide type inlay hints for initializations of closures  This PR adds an option to hide the inlay hints for `let IDENT_PAT = CLOSURE_EXPR;`, which is a somewhat common coding pattern. Currently the inlay hints for the assigned variable and the closure expression itself are both displayed, making it rather repetitive. In order to be consistent with closure return type hints, only closures with block bodies will be hid by this option. Personally I'd feel comfortable making it always enabled (or at least when closure return type hints are enabled), but considering the precedent set in rust-lang#10761, I introduced an off-by-default option for this. changelog feature: option to hide type inlay hints for initializations of closures
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 26, 2024
[`to_string_trait_impl`]: avoid linting if the impl is a specialization Fixes rust-lang#12263 Oh well... rust-lang/rust-clippy#12122 (comment) 🙃 changelog: [`to_string_trait_impl`]: avoid linting if the impl is a specialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when you run
make -jNit's likely that you'll remove compiler-rt andthen it won't get cp'd back into the right place. I believe the reason for this
is that the compiler-rt library target never got updated so make decided it
never needed to copy the files back into place. The files were all there at the
beginning of
make, but then we may clean out the stage0 versions if we unzipthe snapshot again.
Closes #12268