Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue for m68k_target_feature #134328

Open
2 tasks
taiki-e opened this issue Dec 15, 2024 · 0 comments
Open
2 tasks

Tracking Issue for m68k_target_feature #134328

taiki-e opened this issue Dec 15, 2024 · 0 comments
Labels
A-target-feature Area: Enabling/disabling target features like AVX, Neon, etc. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC O-motorola68k Target: Rust from the parallel universe where the Amiga won.

Comments

@taiki-e
Copy link
Member

taiki-e commented Dec 15, 2024

This is a tracking issue for M68k architecture specific part of #44839 (RFC 2045 (rust-lang/rfcs#2045)).
The feature gate for the issue is #![feature(m68k_target_feature)].

About tracking issues

Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.
Discussion comments will get marked as off-topic or deleted.
Repeated discussions on the tracking issue may lead to the tracking issue getting locked.

Steps

Unresolved Questions

  • isa-68000 is baseline of this architecture, so it may not actually need to be expressed as a target feature.

Implementation history

@rustbot label +O-motorola68k +A-target-feature

@taiki-e taiki-e added the C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC label Dec 15, 2024
@rustbot rustbot added A-target-feature Area: Enabling/disabling target features like AVX, Neon, etc. O-motorola68k Target: Rust from the parallel universe where the Amiga won. labels Dec 15, 2024
jieyouxu added a commit to jieyouxu/rust that referenced this issue Dec 15, 2024
…kingjubilee

Add m68k_target_feature

This adds the following unstable target features (tracking issue: rust-lang#134328):

- isa-68000
- isa-68010
- isa-68020
- isa-68030
- isa-68040
- isa-68060
- isa-68881
- isa-68882

The feature names and implied features are match with [definitions in LLVM](https://github.com/llvm/llvm-project/blob/llvmorg-19.1.0/llvm/lib/Target/M68k/M68k.td#L21-L57).

isa-68881 and isa-68882 are FPU ISA features.
isa-68881 is needed to support input/output in floating-point regs in inline assembly. isa-68020 is needed to implement taiki-e/atomic-maybe-uninit#28 more robustly.

cc `@glaubitz` `@ricky26` (designated developers  of [m68k-unknown-linux-gnu](https://doc.rust-lang.org/nightly/rustc/platform-support/m68k-unknown-linux-gnu.html#designated-developers))
r? workingjubilee

`@rustbot` label +O-motorola68k +A-target-feature
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Dec 15, 2024
Rollup merge of rust-lang#134329 - taiki-e:m68k-target-feature, r=workingjubilee

Add m68k_target_feature

This adds the following unstable target features (tracking issue: rust-lang#134328):

- isa-68000
- isa-68010
- isa-68020
- isa-68030
- isa-68040
- isa-68060
- isa-68881
- isa-68882

The feature names and implied features are match with [definitions in LLVM](https://github.com/llvm/llvm-project/blob/llvmorg-19.1.0/llvm/lib/Target/M68k/M68k.td#L21-L57).

isa-68881 and isa-68882 are FPU ISA features.
isa-68881 is needed to support input/output in floating-point regs in inline assembly. isa-68020 is needed to implement taiki-e/atomic-maybe-uninit#28 more robustly.

cc `@glaubitz` `@ricky26` (designated developers  of [m68k-unknown-linux-gnu](https://doc.rust-lang.org/nightly/rustc/platform-support/m68k-unknown-linux-gnu.html#designated-developers))
r? workingjubilee

`@rustbot` label +O-motorola68k +A-target-feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-target-feature Area: Enabling/disabling target features like AVX, Neon, etc. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC O-motorola68k Target: Rust from the parallel universe where the Amiga won.
Projects
None yet
Development

No branches or pull requests

2 participants