Add m68k_target_feature #134329
Add m68k_target_feature #134329
Conversation
rustbot
added
S-waiting-on-review
|
CC @knickish |
|
so these are mostly "ISA levels" in the Armv8.1, Armv8.2 mode, right? except 68881 is separate? is this another "we decided to be cute and named the FPU like a CPU but off by 1" situation like with the x87? |
In my understanding, yes. At least as far as the ones listed in M68000 FAMILY Programmer's Reference Manual, microprocessor names end with “0XX” and coprocessor names end with “[38]XX”:
|
|
welp, seems fine. I wonder if the m68k-unknown-linux-gnu target may want to adopt a specific feature baseline but that's irrelevant to this PR. @bors r+ rollup |
bors
added
S-waiting-on-bors
Rollup of 4 pull requests Successful merges: - rust-lang#134111 (Fix `--nocapture` for run-make tests) - rust-lang#134329 (Add m68k_target_feature) - rust-lang#134331 (bootstrap: make ./x test error-index work) - rust-lang#134339 (Pass `TyCtxt` to early diagostics decoration) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#134329 - taiki-e:m68k-target-feature, r=workingjubilee Add m68k_target_feature This adds the following unstable target features (tracking issue: rust-lang#134328): - isa-68000 - isa-68010 - isa-68020 - isa-68030 - isa-68040 - isa-68060 - isa-68881 - isa-68882 The feature names and implied features are match with [definitions in LLVM](https://github.com/llvm/llvm-project/blob/llvmorg-19.1.0/llvm/lib/Target/M68k/M68k.td#L21-L57). isa-68881 and isa-68882 are FPU ISA features. isa-68881 is needed to support input/output in floating-point regs in inline assembly. isa-68020 is needed to implement taiki-e/atomic-maybe-uninit#28 more robustly. cc `@glaubitz` `@ricky26` (designated developers of [m68k-unknown-linux-gnu](https://doc.rust-lang.org/nightly/rustc/platform-support/m68k-unknown-linux-gnu.html#designated-developers)) r? workingjubilee `@rustbot` label +O-motorola68k +A-target-feature
…llaumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#134111 (Fix `--nocapture` for run-make tests) - rust-lang#134202 (Remove `rustc::existing_doc_keyword` lint) - rust-lang#134314 (Make sure to use normalized ty for unevaluated const in default struct value) - rust-lang#134329 (Add m68k_target_feature) - rust-lang#134342 (crashes: more tests) - rust-lang#134354 (Handle fndef rendering together with signature rendering) Failed merges: - rust-lang#133265 (Add a range argument to vec.extract_if) r? `@ghost` `@rustbot` modify labels: rollup
This adds the following unstable target features (tracking issue: #134328):
The feature names and implied features are match with definitions in LLVM.
isa-68881 and isa-68882 are FPU ISA features.
isa-68881 is needed to support input/output in floating-point regs in inline assembly. isa-68020 is needed to implement taiki-e/atomic-maybe-uninit#28 more robustly.
cc @glaubitz @ricky26 (designated developers of m68k-unknown-linux-gnu)
r? workingjubilee
@rustbot label +O-motorola68k +A-target-feature