Add a range argument to vec.extract_if #133265
Open
+105
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
tgross35
reviewed
Nov 20, 2024
| /// ``` | ||
| /// #![feature(extract_if)] | ||
| /// let mut items = vec![0, 0, 0, 0, 0, 0, 0, 1, 2, 1, 2, 1, 2]; | ||
| /// let ones = items.extract_if(7.., |x| *x == 1).collect::<Vec<_>>(); |
There was a problem hiding this comment.
Maybe change one of the first few 0s to 1 to indicate they don't get extracted (out of range)?
There was a problem hiding this comment.
Hrm, I wanted to show the "I have a prefix that I know doesn't contain those things, so I can skip them" use.
the8472
force-pushed
the
extract-if-ranges
branch
from
34ed582
to
0076504
Compare
This comment has been minimized.
This comment has been minimized.
cuviper
reviewed
Nov 20, 2024
cuviper
reviewed
Nov 20, 2024
the8472
force-pushed
the
extract-if-ranges
branch
from
0076504
to
d8ce784
Compare
This comment has been minimized.
This comment has been minimized.
since drain-on-drop behavior was removed those bounds no longer serve a purpose
the8472
force-pushed
the
extract-if-ranges
branch
from
5d0e0a7
to
aabed33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracking issue: #43244
This adds the range argument requested in #43244 (comment)