Add a range argument to vec.extract_if #133265

the8472 · 2024-11-20T21:58:04Z

tracking issue: #43244

This adds the range argument requested in #43244 (comment)

rustbot · 2024-11-20T21:58:13Z

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

tgross35 · 2024-11-20T22:05:33Z

library/alloc/src/vec/mod.rs

+    /// ```
+    /// #![feature(extract_if)]
+    /// let mut items = vec![0, 0, 0, 0, 0, 0, 0, 1, 2, 1, 2, 1, 2];
+    /// let ones = items.extract_if(7.., |x| *x == 1).collect::<Vec<_>>();


Maybe change one of the first few 0s to 1 to indicate they don't get extracted (out of range)?

Hrm, I wanted to show the "I have a prefix that I know doesn't contain those things, so I can skip them" use.

library/alloc/src/vec/extract_if.rs

cuviper

LGTM.

The FCP finished -- do you want to go ahead and add the stabilization too?

library/alloc/tests/vec.rs

tgross35 · 2024-12-06T20:22:33Z

r? @cuviper (sorry, I didn't realize this was assigned to me)

The FCP finished -- do you want to go ahead and add the stabilization too?

Since this is a pretty significant API and implementation change, maybe it would be good to hold off for a couple of weeks? In case anyone using this API unstably has feedback after the change (I doubt it, but doesn't hurt).

the8472 · 2024-12-06T20:36:12Z

Changing and stabilizing in the same PR doesn't seem ideal to me either, especially when the change happened parallel to the FCP. I think it should bake a few days at least.

cuviper · 2024-12-06T20:37:26Z

@bors r+

bors · 2024-12-06T20:37:30Z

📌 Commit 414acda has been approved by cuviper

It is now in the queue for this repository.

Add a range argument to vec.extract_if tracking issue: rust-lang#43244 This adds the range argument requested in rust-lang#43244 (comment)

…kingjubilee Rollup of 11 pull requests Successful merges: - rust-lang#131669 (lint: change help for pointers to dyn types in FFI) - rust-lang#133265 (Add a range argument to vec.extract_if) - rust-lang#133733 ( compiletest: show the difference between the normalized output and the actual output for lines which didn't match) - rust-lang#133955 (Pass the arch rather than full target name to windows_registry::find_tool) - rust-lang#133967 ([AIX] Pass -bnoipath when adding rust upstream dynamic crates) - rust-lang#133976 (Removed Unnecessary Spaces From RELEASES.md) - rust-lang#133980 ([AIX] Remove option "-n" from AIX "ln" command) - rust-lang#133987 (Define acronym for thread local storage) - rust-lang#133992 (Actually walk into lifetimes and attrs in `EarlyContextAndPass`) - rust-lang#133993 (Fix: typo in E0751 error explanation) - rust-lang#133996 (Move most tests for `-l` and `#[link(..)]` into `tests/ui/link-native-libs`) r? `@ghost` `@rustbot` modify labels: rollup

Add a range argument to vec.extract_if tracking issue: rust-lang#43244 This adds the range argument requested in rust-lang#43244 (comment)

…kingjubilee Rollup of 5 pull requests Successful merges: - rust-lang#131669 (lint: change help for pointers to dyn types in FFI) - rust-lang#133184 (wasi/fs: Improve stopping condition for <ReadDir as Iterator>::next) - rust-lang#133265 (Add a range argument to vec.extract_if) - rust-lang#133456 (Add licenses + Run `cargo update`) - rust-lang#133767 (Add more info on type/trait mismatches for different crate versions) Failed merges: - rust-lang#133522 (Don't suggest restricting bound with unstable traits on stable and mention it's unstable on nightly) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2024-12-08T12:05:28Z

☔ The latest upstream changes (presumably #133522) made this pull request unmergeable. Please resolve the merge conflicts.

…llaumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#134111 (Fix `--nocapture` for run-make tests) - rust-lang#134202 (Remove `rustc::existing_doc_keyword` lint) - rust-lang#134314 (Make sure to use normalized ty for unevaluated const in default struct value) - rust-lang#134329 (Add m68k_target_feature) - rust-lang#134342 (crashes: more tests) - rust-lang#134354 (Handle fndef rendering together with signature rendering) Failed merges: - rust-lang#133265 (Add a range argument to vec.extract_if) r? `@ghost` `@rustbot` modify labels: rollup

cuviper · 2024-12-16T20:30:04Z

I think you forgot the "extraxt" typo fix when you rebased.

since drain-on-drop behavior was removed those bounds no longer serve a purpose

the8472 · 2024-12-16T21:07:43Z

Indeed, fixed.

@bors r=cuviper

bors · 2024-12-16T21:07:46Z

📌 Commit 44790c4 has been approved by cuviper

It is now in the queue for this repository.

Add a range argument to vec.extract_if tracking issue: rust-lang#43244 This adds the range argument requested in rust-lang#43244 (comment)

Rollup of 9 pull requests Successful merges: - rust-lang#133265 (Add a range argument to vec.extract_if) - rust-lang#134202 (Remove `rustc::existing_doc_keyword` lint) - rust-lang#134354 (Handle fndef rendering together with signature rendering) - rust-lang#134365 (Rename `rustc_mir_build::build` to `builder`) - rust-lang#134368 (Use links to edition guide for edition migrations) - rust-lang#134388 (Update books) - rust-lang#134397 (rustc_borrowck: Suggest changing `&raw const` to `&raw mut` if applicable) - rust-lang#134398 (AIX: add alignment info for test) - rust-lang#134400 (Fix some comments related to upvars handling) Failed merges: - rust-lang#134399 (Do not do if ! else, use unnegated cond and swap the branches instead) r? `@ghost` `@rustbot` modify labels: rollup

Add a range argument to vec.extract_if tracking issue: rust-lang#43244 This adds the range argument requested in rust-lang#43244 (comment)

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#133265 (Add a range argument to vec.extract_if) - rust-lang#133801 (Promote powerpc64le-unknown-linux-musl to tier 2 with host tools) - rust-lang#134323 (coverage: Dismantle `map_data.rs` by moving its responsibilities elsewhere) - rust-lang#134378 (An octuple of polonius fact generation cleanups) - rust-lang#134408 (Regression test for RPIT inheriting lifetime from projection) - rust-lang#134423 (bootstrap: use specific-purpose ui test path for `test_valid` self-test) - rust-lang#134426 (Fix typo in uint_macros.rs) Failed merges: - rust-lang#133103 (Pass FnAbi to find_mir_or_eval_fn) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned tgross35 Nov 20, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 20, 2024

This comment has been minimized.

Sign in to view

tgross35 reviewed Nov 20, 2024

View reviewed changes

the8472 force-pushed the extract-if-ranges branch from 34ed582 to 0076504 Compare November 20, 2024 22:16

This comment has been minimized.

Sign in to view

cuviper reviewed Nov 20, 2024

View reviewed changes

library/alloc/src/vec/extract_if.rs Show resolved Hide resolved

cuviper reviewed Nov 20, 2024

View reviewed changes

library/alloc/src/vec/extract_if.rs Outdated Show resolved Hide resolved

the8472 force-pushed the extract-if-ranges branch from 0076504 to d8ce784 Compare November 20, 2024 22:46

This comment has been minimized.

Sign in to view

the8472 force-pushed the extract-if-ranges branch from 5d0e0a7 to aabed33 Compare November 20, 2024 23:30

cuviper approved these changes Dec 6, 2024

View reviewed changes

library/alloc/tests/vec.rs Outdated Show resolved Hide resolved

rustbot assigned cuviper and unassigned tgross35 Dec 6, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 6, 2024

workingjubilee mentioned this pull request Dec 7, 2024

Rollup of 11 pull requests #134002

Closed

workingjubilee mentioned this pull request Dec 8, 2024

Rollup of 5 pull requests #134027

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 8, 2024

GuillaumeGomez mentioned this pull request Dec 16, 2024

Rollup of 6 pull requests #134359

Closed

the8472 force-pushed the extract-if-ranges branch from 414acda to 8f76b97 Compare December 16, 2024 02:14

the8472 added 4 commits December 16, 2024 22:06

Add a range argument to vec.extract_if

ab6ad1a

remove bounds from vec and linkedlist ExtractIf

03f1b73

since drain-on-drop behavior was removed those bounds no longer serve a purpose

update uses of extract_if in the compiler

fe52150

remove obsolete comment and pub(super) visibility

44790c4

the8472 force-pushed the extract-if-ranges branch from 8f76b97 to 44790c4 Compare December 16, 2024 21:07

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 16, 2024

jhpratt mentioned this pull request Dec 17, 2024

Rollup of 9 pull requests #134411

Closed

jieyouxu mentioned this pull request Dec 17, 2024

Rollup of 9 pull requests #134430

Closed

jieyouxu mentioned this pull request Dec 17, 2024

Rollup of 8 pull requests #134431

Closed

matthiaskrgr mentioned this pull request Dec 17, 2024

Rollup of 7 pull requests #134439

Merged

bors merged commit 938742e into rust-lang:master Dec 18, 2024
6 checks passed

rustbot added this to the 1.85.0 milestone Dec 18, 2024

zhassan-aws mentioned this pull request Dec 20, 2024

Compilation error with 2024-12-19 rust toolchain AeneasVerif/charon#505

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a range argument to vec.extract_if #133265

Add a range argument to vec.extract_if #133265

the8472 commented Nov 20, 2024

rustbot commented Nov 20, 2024

This comment has been minimized.

tgross35 Nov 20, 2024

the8472 Nov 20, 2024

This comment has been minimized.

This comment has been minimized.

cuviper left a comment

tgross35 commented Dec 6, 2024

the8472 commented Dec 6, 2024

cuviper commented Dec 6, 2024

bors commented Dec 6, 2024

bors commented Dec 8, 2024

cuviper commented Dec 16, 2024

the8472 commented Dec 16, 2024

bors commented Dec 16, 2024

Add a range argument to vec.extract_if #133265

Add a range argument to vec.extract_if #133265

Conversation

the8472 commented Nov 20, 2024

rustbot commented Nov 20, 2024

This comment has been minimized.

tgross35 Nov 20, 2024

Choose a reason for hiding this comment

the8472 Nov 20, 2024

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

cuviper left a comment

Choose a reason for hiding this comment

tgross35 commented Dec 6, 2024

the8472 commented Dec 6, 2024

cuviper commented Dec 6, 2024

bors commented Dec 6, 2024

bors commented Dec 8, 2024

cuviper commented Dec 16, 2024

the8472 commented Dec 16, 2024

bors commented Dec 16, 2024