Move most tests for `-l` and `#[link(..)]` into `tests/ui/link-native-libs` #133996

Zalathar · 2024-12-07T02:19:54Z

Tests for the closely-related -l flag and #[link(..)] attribute are spread across a few different directories, and in some cases have ended up in a test directory intended for other linker-related functionality.

This PR moves most of them into a single tests/ui/link-native-libs directory.

Part of #133895.

try-job: i686-mingw

r? jieyouxu

jieyouxu

Thanks for the cleanup 🩵! You can r=me after PR CI is green.

Zalathar · 2024-12-07T02:24:37Z

I noticed this while working on #132934, but at that time I didn't want to get sidetracked by fixing it. Seeing the UI test cleanup issue reminded me to go back and do something about it.

src/tools/tidy/src/ui_tests.rs

Zalathar · 2024-12-07T03:36:49Z

🟩

@bors r=jieyouxu rollup

bors · 2024-12-07T03:36:52Z

📌 Commit 0a48b96 has been approved by jieyouxu

It is now in the queue for this repository.

…eyouxu Move most tests for `-l` and `#[link(..)]` into `tests/ui/link-native-libs` Tests for the closely-related `-l` flag and `#[link(..)]` attribute are spread across a few different directories, and in some cases have ended up in a test directory intended for other linker-related functionality. This PR moves most of them into a single `tests/ui/link-native-libs` directory. --- Part of rust-lang#133895. r? jieyouxu

…kingjubilee Rollup of 11 pull requests Successful merges: - rust-lang#131669 (lint: change help for pointers to dyn types in FFI) - rust-lang#133265 (Add a range argument to vec.extract_if) - rust-lang#133733 ( compiletest: show the difference between the normalized output and the actual output for lines which didn't match) - rust-lang#133955 (Pass the arch rather than full target name to windows_registry::find_tool) - rust-lang#133967 ([AIX] Pass -bnoipath when adding rust upstream dynamic crates) - rust-lang#133976 (Removed Unnecessary Spaces From RELEASES.md) - rust-lang#133980 ([AIX] Remove option "-n" from AIX "ln" command) - rust-lang#133987 (Define acronym for thread local storage) - rust-lang#133992 (Actually walk into lifetimes and attrs in `EarlyContextAndPass`) - rust-lang#133993 (Fix: typo in E0751 error explanation) - rust-lang#133996 (Move most tests for `-l` and `#[link(..)]` into `tests/ui/link-native-libs`) r? `@ghost` `@rustbot` modify labels: rollup

…eyouxu Move most tests for `-l` and `#[link(..)]` into `tests/ui/link-native-libs` Tests for the closely-related `-l` flag and `#[link(..)]` attribute are spread across a few different directories, and in some cases have ended up in a test directory intended for other linker-related functionality. This PR moves most of them into a single `tests/ui/link-native-libs` directory. --- Part of rust-lang#133895. r? jieyouxu

…kingjubilee Rollup of 10 pull requests Successful merges: - rust-lang#133522 (Don't suggest restricting bound with unstable traits on stable and mention it's unstable on nightly) - rust-lang#133733 ( compiletest: show the difference between the normalized output and the actual output for lines which didn't match) - rust-lang#133861 (Add allocate_bytes and refactor allocate_str in InterpCx for raw byte…) - rust-lang#133967 ([AIX] Pass -bnoipath when adding rust upstream dynamic crates) - rust-lang#133976 (Removed Unnecessary Spaces From RELEASES.md) - rust-lang#133980 ([AIX] Remove option "-n" from AIX "ln" command) - rust-lang#133987 (Define acronym for thread local storage) - rust-lang#133992 (Actually walk into lifetimes and attrs in `EarlyContextAndPass`) - rust-lang#133993 (Fix: typo in E0751 error explanation) - rust-lang#133996 (Move most tests for `-l` and `#[link(..)]` into `tests/ui/link-native-libs`) r? `@ghost` `@rustbot` modify labels: rollup

…eyouxu Move most tests for `-l` and `#[link(..)]` into `tests/ui/link-native-libs` Tests for the closely-related `-l` flag and `#[link(..)]` attribute are spread across a few different directories, and in some cases have ended up in a test directory intended for other linker-related functionality. This PR moves most of them into a single `tests/ui/link-native-libs` directory. --- Part of rust-lang#133895. r? jieyouxu

[TEST] Rollup of 5 pull requests Successful merges: - rust-lang#133987 (Define acronym for thread local storage) - rust-lang#133992 (Actually walk into lifetimes and attrs in `EarlyContextAndPass`) - rust-lang#133993 (Fix: typo in E0751 error explanation) - rust-lang#133996 (Move most tests for `-l` and `#[link(..)]` into `tests/ui/link-native-libs`) - rust-lang#134020 (Remove unnecessary `int_type_width_signed` function) try-job: i686-mingw r? `@ghost` `@rustbot` modify labels: rollup

workingjubilee · 2024-12-08T22:19:03Z

@bors r-

workingjubilee · 2024-12-08T22:19:20Z

@bors try

bors · 2024-12-08T22:20:30Z

⌛ Trying commit 0a48b96 with merge e844b3d...

Move most tests for `-l` and `#[link(..)]` into `tests/ui/link-native-libs` Tests for the closely-related `-l` flag and `#[link(..)]` attribute are spread across a few different directories, and in some cases have ended up in a test directory intended for other linker-related functionality. This PR moves most of them into a single `tests/ui/link-native-libs` directory. --- Part of rust-lang#133895. try-job: i686-mingw r? jieyouxu

bors · 2024-12-09T01:03:57Z

☀️ Try build successful - checks-actions
Build commit: e844b3d (e844b3da21d6b0fa8df59af7d98f7a62d7eeb307)

jieyouxu · 2024-12-09T01:18:08Z

This only moved tests around.
@bors r+ rollup

bors · 2024-12-09T01:18:11Z

📌 Commit 0a48b96 has been approved by jieyouxu

It is now in the queue for this repository.

…eyouxu Move most tests for `-l` and `#[link(..)]` into `tests/ui/link-native-libs` Tests for the closely-related `-l` flag and `#[link(..)]` attribute are spread across a few different directories, and in some cases have ended up in a test directory intended for other linker-related functionality. This PR moves most of them into a single `tests/ui/link-native-libs` directory. --- Part of rust-lang#133895. try-job: i686-mingw r? jieyouxu

…llaumeGomez Rollup of 9 pull requests Successful merges: - rust-lang#133184 (wasi/fs: Improve stopping condition for <ReadDir as Iterator>::next) - rust-lang#133955 (Pass the arch rather than full target name to windows_registry::find_tool) - rust-lang#133967 ([AIX] Pass -bnoipath when adding rust upstream dynamic crates) - rust-lang#133970 ([AIX] Replace sa_sigaction with sa_union.__su_sigaction for AIX) - rust-lang#133980 ([AIX] Remove option "-n" from AIX "ln" command) - rust-lang#133996 (Move most tests for `-l` and `#[link(..)]` into `tests/ui/link-native-libs`) - rust-lang#134017 (Don't use `AsyncFnOnce::CallOnceFuture` bounds for signature deduction) - rust-lang#134023 (handle cygwin environment in `install::sanitize_sh`) - rust-lang#134053 (rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 10)) r? `@ghost` `@rustbot` modify labels: rollup

…eyouxu Move most tests for `-l` and `#[link(..)]` into `tests/ui/link-native-libs` Tests for the closely-related `-l` flag and `#[link(..)]` attribute are spread across a few different directories, and in some cases have ended up in a test directory intended for other linker-related functionality. This PR moves most of them into a single `tests/ui/link-native-libs` directory. --- Part of rust-lang#133895. try-job: i686-mingw r? jieyouxu

Rollup of 8 pull requests Successful merges: - rust-lang#133184 (wasi/fs: Improve stopping condition for <ReadDir as Iterator>::next) - rust-lang#133967 ([AIX] Pass -bnoipath when adding rust upstream dynamic crates) - rust-lang#133970 ([AIX] Replace sa_sigaction with sa_union.__su_sigaction for AIX) - rust-lang#133980 ([AIX] Remove option "-n" from AIX "ln" command) - rust-lang#133996 (Move most tests for `-l` and `#[link(..)]` into `tests/ui/link-native-libs`) - rust-lang#134017 (Don't use `AsyncFnOnce::CallOnceFuture` bounds for signature deduction) - rust-lang#134023 (handle cygwin environment in `install::sanitize_sh`) - rust-lang#134053 (rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 10)) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 9 pull requests Successful merges: - rust-lang#133996 (Move most tests for `-l` and `#[link(..)]` into `tests/ui/link-native-libs`) - rust-lang#134012 (Grammar fixes) - rust-lang#134032 (docs: better examples for `std::ops::ControlFlow`) - rust-lang#134040 (bootstrap: print{ln}! -> eprint{ln}! (take 2)) - rust-lang#134043 (Add test to check unicode identifier version) - rust-lang#134053 (rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 10)) - rust-lang#134055 (interpret: clean up deduplicating allocation functions) - rust-lang#134073 (dataflow_const_prop: do not eval a ptr address in SwitchInt) - rust-lang#134084 (Fix typo in RFC mention 3598 -> 3593) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#133996 - Zalathar:ui-link-native-libs, r=jieyouxu Move most tests for `-l` and `#[link(..)]` into `tests/ui/link-native-libs` Tests for the closely-related `-l` flag and `#[link(..)]` attribute are spread across a few different directories, and in some cases have ended up in a test directory intended for other linker-related functionality. This PR moves most of them into a single `tests/ui/link-native-libs` directory. --- Part of rust-lang#133895. try-job: i686-mingw r? jieyouxu

Zalathar added 2 commits December 7, 2024 12:42

Move tests for -l and #[link(..)] into tests/ui/link-native-libs

f884f18

Move more tests into tests/ui/link-native-libs

0a48b96

rustbot assigned jieyouxu Dec 7, 2024

jieyouxu approved these changes Dec 7, 2024

View reviewed changes

jieyouxu mentioned this pull request Dec 7, 2024

Tracking Issue for ui test suite improvements #133895

Open

jieyouxu reviewed Dec 7, 2024

View reviewed changes

src/tools/tidy/src/ui_tests.rs Show resolved Hide resolved

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 7, 2024

workingjubilee mentioned this pull request Dec 7, 2024

Rollup of 11 pull requests #134002

Closed

workingjubilee mentioned this pull request Dec 8, 2024

Rollup of 10 pull requests #134019

Closed

workingjubilee mentioned this pull request Dec 8, 2024

[TEST] Rollup of 5 pull requests #134026

Closed

bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 8, 2024

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 8, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 9, 2024

GuillaumeGomez mentioned this pull request Dec 9, 2024

Rollup of 9 pull requests #134057

Closed

jieyouxu mentioned this pull request Dec 9, 2024

Rollup of 12 pull requests #134067

Closed

jieyouxu mentioned this pull request Dec 9, 2024

Rollup of 8 pull requests #134068

Closed

fmease mentioned this pull request Dec 9, 2024

Rollup of 9 pull requests #134096

Merged

bors merged commit df5ec03 into rust-lang:master Dec 10, 2024
7 checks passed

rustbot added this to the 1.85.0 milestone Dec 10, 2024

Zalathar deleted the ui-link-native-libs branch December 10, 2024 08:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Move most tests for `-l` and `#[link(..)]` into `tests/ui/link-native-libs` #133996

Move most tests for `-l` and `#[link(..)]` into `tests/ui/link-native-libs` #133996

Uh oh!

Zalathar commented Dec 7, 2024 •

edited by workingjubilee

Loading

Uh oh!

jieyouxu left a comment

Uh oh!

Zalathar commented Dec 7, 2024

Uh oh!

Uh oh!

Zalathar commented Dec 7, 2024

Uh oh!

bors commented Dec 7, 2024

Uh oh!

workingjubilee commented Dec 8, 2024

Uh oh!

workingjubilee commented Dec 8, 2024

Uh oh!

bors commented Dec 8, 2024

Uh oh!

bors commented Dec 9, 2024

Uh oh!

jieyouxu commented Dec 9, 2024

Uh oh!

bors commented Dec 9, 2024

Uh oh!

Uh oh!

Uh oh!

Move most tests for -l and #[link(..)] into tests/ui/link-native-libs #133996

Move most tests for -l and #[link(..)] into tests/ui/link-native-libs #133996

Uh oh!

Conversation

Zalathar commented Dec 7, 2024 • edited by workingjubilee Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

Zalathar commented Dec 7, 2024

Uh oh!

Uh oh!

Zalathar commented Dec 7, 2024

Uh oh!

bors commented Dec 7, 2024

Uh oh!

workingjubilee commented Dec 8, 2024

Uh oh!

workingjubilee commented Dec 8, 2024

Uh oh!

bors commented Dec 8, 2024

Uh oh!

bors commented Dec 9, 2024

Uh oh!

jieyouxu commented Dec 9, 2024

Uh oh!

bors commented Dec 9, 2024

Uh oh!

Uh oh!

Uh oh!

Move most tests for `-l` and `#[link(..)]` into `tests/ui/link-native-libs` #133996

Move most tests for `-l` and `#[link(..)]` into `tests/ui/link-native-libs` #133996

Zalathar commented Dec 7, 2024 •

edited by workingjubilee

Loading