Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: rename issue-\d+.rs tests to have meaningful names (part 10) #134053

Merged
merged 2 commits into from
Dec 10, 2024
Merged

rustdoc: rename issue-\d+.rs tests to have meaningful names (part 10) #134053

merged 2 commits into from
Dec 10, 2024

Conversation

notriddle
Copy link
Contributor

Follow up #130287 et al

As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.

@rustbot
Copy link
Collaborator

rustbot commented Dec 9, 2024

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Dec 9, 2024
@GuillaumeGomez
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 9, 2024

📌 Commit b531854 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 9, 2024
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 9, 2024
@GuillaumeGomez
Rollup merge of rust-lang#134053 - notriddle:notriddle/issue-d, r=Gui…
0a7c477 
…llaumeGomez

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 10)

Follow up rust-lang#130287 et al

As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Dec 9, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 9, 2024
@bors
Auto merge of rust-lang#134057 - GuillaumeGomez:rollup-kzesbgh, r=Gui…
1da727e 
…llaumeGomez

Rollup of 9 pull requests

Successful merges:

 - rust-lang#133184 (wasi/fs: Improve stopping condition for <ReadDir as Iterator>::next)
 - rust-lang#133955 (Pass the arch rather than full target name to windows_registry::find_tool)
 - rust-lang#133967 ([AIX] Pass -bnoipath when adding rust upstream dynamic crates)
 - rust-lang#133970 ([AIX] Replace sa_sigaction with sa_union.__su_sigaction for AIX)
 - rust-lang#133980 ([AIX] Remove option "-n" from AIX "ln" command)
 - rust-lang#133996 (Move most tests for `-l` and `#[link(..)]` into `tests/ui/link-native-libs`)
 - rust-lang#134017 (Don't use `AsyncFnOnce::CallOnceFuture` bounds for signature deduction)
 - rust-lang#134023 (handle cygwin environment in `install::sanitize_sh`)
 - rust-lang#134053 (rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 10))

r? `@ghost`
`@rustbot` modify labels: rollup
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Dec 9, 2024
@jieyouxu
Rollup merge of rust-lang#134053 - notriddle:notriddle/issue-d, r=Gui…
e6f32e8 
…llaumeGomez

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 10)

Follow up rust-lang#130287 et al

As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.
@jieyouxu jieyouxu mentioned this pull request Dec 9, 2024
Closed
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Dec 9, 2024
@jieyouxu
Rollup merge of rust-lang#134053 - notriddle:notriddle/issue-d, r=Gui…
f932b7b 
…llaumeGomez

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 10)

Follow up rust-lang#130287 et al

As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.
@jieyouxu jieyouxu mentioned this pull request Dec 9, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 9, 2024
@bors
Auto merge of rust-lang#134068 - jieyouxu:rollup-wv3b24c, r=jieyouxu
39e097b 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#133184 (wasi/fs: Improve stopping condition for <ReadDir as Iterator>::next)
 - rust-lang#133967 ([AIX] Pass -bnoipath when adding rust upstream dynamic crates)
 - rust-lang#133970 ([AIX] Replace sa_sigaction with sa_union.__su_sigaction for AIX)
 - rust-lang#133980 ([AIX] Remove option "-n" from AIX "ln" command)
 - rust-lang#133996 (Move most tests for `-l` and `#[link(..)]` into `tests/ui/link-native-libs`)
 - rust-lang#134017 (Don't use `AsyncFnOnce::CallOnceFuture` bounds for signature deduction)
 - rust-lang#134023 (handle cygwin environment in `install::sanitize_sh`)
 - rust-lang#134053 (rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 10))

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 9, 2024
@bors
Auto merge of rust-lang#134068 - jieyouxu:rollup-wv3b24c, r=jieyouxu
070f378 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#133184 (wasi/fs: Improve stopping condition for <ReadDir as Iterator>::next)
 - rust-lang#133967 ([AIX] Pass -bnoipath when adding rust upstream dynamic crates)
 - rust-lang#133970 ([AIX] Replace sa_sigaction with sa_union.__su_sigaction for AIX)
 - rust-lang#133980 ([AIX] Remove option "-n" from AIX "ln" command)
 - rust-lang#133996 (Move most tests for `-l` and `#[link(..)]` into `tests/ui/link-native-libs`)
 - rust-lang#134017 (Don't use `AsyncFnOnce::CallOnceFuture` bounds for signature deduction)
 - rust-lang#134023 (handle cygwin environment in `install::sanitize_sh`)
 - rust-lang#134053 (rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 10))

r? `@ghost`
`@rustbot` modify labels: rollup
@fmease fmease mentioned this pull request Dec 9, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 10, 2024
@bors
Auto merge of rust-lang#134096 - fmease:rollup-0asgoo8, r=fmease
ff7906b 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#133996 (Move most tests for `-l` and `#[link(..)]` into `tests/ui/link-native-libs`)
 - rust-lang#134012 (Grammar fixes)
 - rust-lang#134032 (docs: better examples for `std::ops::ControlFlow`)
 - rust-lang#134040 (bootstrap: print{ln}! -> eprint{ln}! (take 2))
 - rust-lang#134043 (Add test to check unicode identifier version)
 - rust-lang#134053 (rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 10))
 - rust-lang#134055 (interpret: clean up deduplicating allocation functions)
 - rust-lang#134073 (dataflow_const_prop: do not eval a ptr address in SwitchInt)
 - rust-lang#134084 (Fix typo in RFC mention 3598 -> 3593)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 76fbe8d into rust-lang:master Dec 10, 2024
6 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 10, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 10, 2024
@rust-timer
Unrolled build for rust-lang#134053
b291cb4 
Rollup merge of rust-lang#134053 - notriddle:notriddle/issue-d, r=GuillaumeGomez

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 10)

Follow up rust-lang#130287 et al

As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.
@notriddle notriddle deleted the notriddle/issue-d branch December 10, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.85.0
Development

Successfully merging this pull request may close these issues.
4 participants
@notriddle @rustbot @GuillaumeGomez @bors