Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grammar fixes #134012

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Grammar fixes #134012

merged 1 commit into from
Dec 10, 2024
+1 −1

Conversation

aarikpokras
Copy link
Contributor

Fixed some grammar in README.md

@rustbot
Copy link
Collaborator

rustbot commented Dec 7, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 7, 2024
@saethlin
Copy link
Member

saethlin commented Dec 8, 2024

Nice find! I agree the grammar you've identified needs some improvement, but I'm not keen on just changing to "integratable".

@saethlin saethlin closed this Dec 8, 2024
@saethlin saethlin reopened this Dec 8, 2024
@saethlin
Copy link
Member

saethlin commented Dec 8, 2024

Sorry about that. Finger slipped.

I can't find "integratable" in major dictionaries, and it's certainly not in my phone's auto complete. Can you try "integrable" or "integrated"? The latter is technically a different tense I suppose but I think it serves the same purpose. English is strange.

@aarikpokras
Copy link
Contributor Author

Sorry about that. My computer somehow recognized that as a word. I'll try to find another one. Sorry!

@aarikpokras
Copy link
Contributor Author

Hi,
I used "integrated". Thank you!

@saethlin
Copy link
Member

saethlin commented Dec 9, 2024

Sorry about that. My computer somehow recognized that as a word. I'll try to find another one. Sorry!

No need to apologize :) Natural languages evolve in real time so it's quite possible this is just uncommon right now.

We try to keep PRs to just 1 commit for small changes like this, because bors doesn't have its own squashing. I'll fixup the history for you, but normally this operation is known as a squash if you want to read about how to do it yourself.

@saethlin
Copy link
Member

saethlin commented Dec 9, 2024

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 9, 2024

📌 Commit 2d71dd5 has been approved by saethlin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 9, 2024
@fmease fmease mentioned this pull request Dec 9, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 10, 2024
@bors
Auto merge of rust-lang#134096 - fmease:rollup-0asgoo8, r=fmease
ff7906b 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#133996 (Move most tests for `-l` and `#[link(..)]` into `tests/ui/link-native-libs`)
 - rust-lang#134012 (Grammar fixes)
 - rust-lang#134032 (docs: better examples for `std::ops::ControlFlow`)
 - rust-lang#134040 (bootstrap: print{ln}! -> eprint{ln}! (take 2))
 - rust-lang#134043 (Add test to check unicode identifier version)
 - rust-lang#134053 (rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 10))
 - rust-lang#134055 (interpret: clean up deduplicating allocation functions)
 - rust-lang#134073 (dataflow_const_prop: do not eval a ptr address in SwitchInt)
 - rust-lang#134084 (Fix typo in RFC mention 3598 -> 3593)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 780b5bb into rust-lang:master Dec 10, 2024
6 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 10, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 10, 2024
@rust-timer
Unrolled build for rust-lang#134012
3d42559 
Rollup merge of rust-lang#134012 - aarikpokras:patch-1, r=saethlin

Grammar fixes

Fixed some grammar in README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.85.0
Development

Successfully merging this pull request may close these issues.
5 participants
@aarikpokras @rustbot @saethlin @bors @Mark-Simulacrum