Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #134096

Merged
merged 21 commits into from
Dec 10, 2024
Merged

Rollup of 9 pull requests #134096

merged 21 commits into from
Dec 10, 2024

Conversation

fmease
Copy link
Member

@fmease fmease commented Dec 9, 2024

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Zalathar and others added 21 commits December 7, 2024 12:42
Signed-off-by: Prajwal S N <prajwalnadig21@gmail.com>
Co-authored-by: Jieyou Xu <jieyouxu@outlook.com>
…eyouxu

Move most tests for `-l` and `#[link(..)]` into `tests/ui/link-native-libs`

Tests for the closely-related `-l` flag and `#[link(..)]` attribute are spread across a few different directories, and in some cases have ended up in a test directory intended for other linker-related functionality.

This PR moves most of them into a single `tests/ui/link-native-libs` directory.

---

Part of rust-lang#133895.

try-job: i686-mingw

r? jieyouxu
Grammar fixes

Fixed some grammar in README.md
docs: better examples for `std::ops::ControlFlow`

Fixes rust-lang#133963. Lesson learnt, never force-push from a bare clone of a repo 💀
…eyouxu

bootstrap: print{ln}! -> eprint{ln}! (take 2)

r? `@jieyouxu`

Reland of rust-lang#133817 with the `print!`s changed as well.
Add test to check unicode identifier version

This adds a test to verify which version of Unicode is used for identifiers. This is part of the language, documented at https://doc.rust-lang.org/nightly/reference/identifiers.html#r-ident.unicode. The version here often changes implicitly due to dependency updates pulling in new versions, and thus we often don't notice it has changed leaving the documentation out of date. The intent here is to have a canary to give us a notification when it changes so that we can update the documentation.
…llaumeGomez

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 10)

Follow up rust-lang#130287 et al

As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.
…oli-obk

interpret: clean up deduplicating allocation functions

The "align" and "kind" arguments would be largely ignored in the "dedup" case, so let's move that to entirely separate function.

Let's also remove support for old-style miri_resolve_frame while we are at it. The docs have already said for a while that this must be set to 1.
dataflow_const_prop: do not eval a ptr address in SwitchInt

Fixes rust-lang#131227.
@rustbot rustbot added A-compiletest Area: The compiletest test runner A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Dec 9, 2024
@fmease
Copy link
Member Author

fmease commented Dec 9, 2024

@bors rollup=never p=5 r+

@bors
Copy link
Contributor

bors commented Dec 9, 2024

📌 Commit 5a33ab0 has been approved by fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 9, 2024
@fmease
Copy link
Member Author

fmease commented Dec 9, 2024

@bors p=3

Re. priority: All PRs are rollup=always

@bors
Copy link
Contributor

bors commented Dec 10, 2024

⌛ Testing commit 5a33ab0 with merge ff7906b...

@bors
Copy link
Contributor

bors commented Dec 10, 2024

☀️ Test successful - checks-actions
Approved by: fmease
Pushing ff7906b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 10, 2024
@bors bors merged commit ff7906b into rust-lang:master Dec 10, 2024
7 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 10, 2024
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#133996 Move most tests for -l and #[link(..)] into `tests/ui/l… 724a3b3474af2a8060d665a718ce09683e9eede2 (link)
#134012 Grammar fixes 3d425590f49ace1d38767f850f4c2474a68a37aa (link)
#134032 docs: better examples for std::ops::ControlFlow 038a8509ec62aac7ea1ec0e7ee16d89470a7f93c (link)
#134040 bootstrap: print{ln}! -> eprint{ln}! (take 2) 759c6e92bbd6b461240be4362a686928863dacc9 (link)
#134043 Add test to check unicode identifier version 1ebd7c7b252885ef8f0620a7a2a99afcecb1fe38 (link)
#134053 rustdoc: rename issue-\d+.rs tests to have meaningful nam… b291cb4f5e97f32659d69be568830e27bea44fdb (link)
#134055 interpret: clean up deduplicating allocation functions 05c3f54c0e896590cbb853f1502761af1a589396 (link)
#134073 dataflow_const_prop: do not eval a ptr address in SwitchInt a3301f0f528e29aafaae1261dce8ea75baf23068 (link)
#134084 Fix typo in RFC mention 3598 -> 3593 6e3399987ddac881e48cc7d1c56099fbc344a187 (link)

previous master: 974ccc12e6

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ff7906b): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.4% [-0.4%, -0.4%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 2.7%, secondary -5.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.7% [2.1%, 3.4%] 2
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-5.2% [-5.2%, -5.2%] 1
All ❌✅ (primary) 2.7% [2.1%, 3.4%] 2

Cycles

Results (secondary -2.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.2% [-2.2%, -2.2%] 1
All ❌✅ (primary) - - 0

Binary size

Results (secondary 0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.0% [0.0%, 0.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Bootstrap: 767.421s -> 767.281s (-0.02%)
Artifact size: 331.00 MiB -> 330.96 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-compiletest Area: The compiletest test runner A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.