Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dataflow_const_prop: do not eval a ptr address in SwitchInt #134073

Merged
merged 1 commit into from
Dec 10, 2024
Merged

dataflow_const_prop: do not eval a ptr address in SwitchInt #134073

merged 1 commit into from
Dec 10, 2024
+26 −18

Conversation

DianQK
Copy link
Member

@DianQK DianQK commented Dec 9, 2024

Fixes #131227.

@rustbot
Copy link
Collaborator

rustbot commented Dec 9, 2024

r? @Nadrieril

rustbot has assigned @Nadrieril.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 9, 2024
DianQK
DianQK commented Dec 9, 2024
View reviewed changes
tests/ui/issues/issue-131227-dataflow-const-prop.rs Outdated
pub fn myfunc() -> i32 {
let var = &raw mut G;
let u: usize = unsafe { std::mem::transmute(var) };
match u {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://rust.godbolt.org/z/aGPocn5jq

@DianQK DianQK mentioned this pull request Dec 9, 2024
Open
@rustbot
Copy link
Collaborator

rustbot commented Dec 9, 2024

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@oli-obk
Copy link
Contributor

oli-obk commented Dec 9, 2024

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 9, 2024

📌 Commit d0986f4 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 9, 2024
@oli-obk oli-obk assigned oli-obk and unassigned Nadrieril Dec 9, 2024
@fmease fmease mentioned this pull request Dec 9, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 10, 2024
@bors
Auto merge of rust-lang#134096 - fmease:rollup-0asgoo8, r=fmease
ff7906b 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#133996 (Move most tests for `-l` and `#[link(..)]` into `tests/ui/link-native-libs`)
 - rust-lang#134012 (Grammar fixes)
 - rust-lang#134032 (docs: better examples for `std::ops::ControlFlow`)
 - rust-lang#134040 (bootstrap: print{ln}! -> eprint{ln}! (take 2))
 - rust-lang#134043 (Add test to check unicode identifier version)
 - rust-lang#134053 (rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 10))
 - rust-lang#134055 (interpret: clean up deduplicating allocation functions)
 - rust-lang#134073 (dataflow_const_prop: do not eval a ptr address in SwitchInt)
 - rust-lang#134084 (Fix typo in RFC mention 3598 -> 3593)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit cb5f03c into rust-lang:master Dec 10, 2024
6 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 10, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 10, 2024
@rust-timer
Unrolled build for rust-lang#134073
a3301f0 
Rollup merge of rust-lang#134073 - DianQK:fix-131227, r=oli-obk

dataflow_const_prop: do not eval a ptr address in SwitchInt

Fixes rust-lang#131227.
@DianQK DianQK deleted the fix-131227 branch December 10, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu left review comments

Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.85.0
Development

Successfully merging this pull request may close these issues.

[ICE]: got a pointer where a ScalarInt was expected: alloc1
7 participants
@DianQK @rustbot @rust-log-analyzer @oli-obk @bors @jieyouxu @Nadrieril