Promote powerpc64le-unknown-linux-musl to tier 2 with host tools #133801

Gelbpunkt · 2024-12-03T15:53:21Z

I'm using crosstool-ng for building a toolchain because GCC 9 from musl-toolchain.sh has float ABI issues (?) and can't compile LLVM, and writing a crosstool-ng config for a target feels less hacky than yet another target specific shell script. I also defined a kernel version, since there wasn't one specified before. If a lower version is desired, just let me know. I also tried to match the rust configure args with the loongarch64 musl tier 2 target.

The resulting compiler works fine, built with DEPLOY=1 ./src/ci/docker/run.sh dist-powerpc64le-linux and tested on Alpine Linux in a VM and on a bare metal POWER8 machine:

qemu-ppc64le:/tmp/rust-nightly-powerpc64le-unknown-linux-musl$ ash install.sh
install: creating uninstall script at /usr/local/lib/rustlib/uninstall.sh
install: installing component 'rustc'
install: installing component 'rust-std-powerpc64le-unknown-linux-musl'
install: installing component 'cargo'
install: installing component 'rustfmt-preview'
install: installing component 'rls-preview'
install: installing component 'rust-analyzer-preview'
install: installing component 'llvm-tools-preview'
install: installing component 'clippy-preview'
install: installing component 'miri-preview'
install: installing component 'rust-analysis-powerpc64le-unknown-linux-musl'
install: installing component 'llvm-bitcode-linker-preview'
install: WARNING: failed to run ldconfig. this may happen when not installing as root. run with --verbose to see the error

    rust installed.

qemu-ppc64le:~$ echo 'fn main() { println!("hello world"); }' > test.rs
qemu-ppc64le:~$ rustc test.rs
qemu-ppc64le:~$ ./test
hello world
qemu-ppc64le:~$ file test
test: ELF 64-bit LSB executable, 64-bit PowerPC or cisco 7500, OpenPOWER ELF V2 ABI, version 1 (SYSV), statically linked, BuildID[sha1]=596ee6abf9add487ebc54fb71c2076fb6faea013, with debug_info, not stripped

try-job: dist-powerpc64le-linux

rustbot · 2024-12-03T15:53:31Z

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-12-03T16:05:12Z

These commits modify compiler targets.
(See the Target Tier Policy.)

This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp.

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

src/doc/rustc/src/platform-support/powerpc64le-unknown-linux-musl.md

ehuss · 2024-12-03T16:28:31Z

r? compiler

Urgau · 2024-12-03T17:42:37Z

The compiler changes looks go to me, r=me on them.
T-bootstrap for the final review.

r? bootstrap
@bors try

…musl-tier-2, r=<try> Promote powerpc64le-unknown-linux-musl to tier 2 with host tools MCP: rust-lang/compiler-team#803 I'm using crosstool-ng for building a toolchain because GCC 9 from `musl-toolchain.sh` has float ABI issues (?) and can't compile LLVM, and writing a crosstool-ng config for a target feels less hacky than yet another target specific shell script. I also defined a kernel version, since there wasn't one specified before. If a lower version is desired, just let me know. I also tried to match the rust configure args with the loongarch64 musl tier 2 target. The resulting compiler works fine, built with `DEPLOY=1 ./src/ci/docker/run.sh dist-powerpc64le-linux` and tested on Alpine Linux in a VM and on a bare metal POWER8 machine: ``` qemu-ppc64le:/tmp/rust-nightly-powerpc64le-unknown-linux-musl$ ash install.sh install: creating uninstall script at /usr/local/lib/rustlib/uninstall.sh install: installing component 'rustc' install: installing component 'rust-std-powerpc64le-unknown-linux-musl' install: installing component 'cargo' install: installing component 'rustfmt-preview' install: installing component 'rls-preview' install: installing component 'rust-analyzer-preview' install: installing component 'llvm-tools-preview' install: installing component 'clippy-preview' install: installing component 'miri-preview' install: installing component 'rust-analysis-powerpc64le-unknown-linux-musl' install: installing component 'llvm-bitcode-linker-preview' install: WARNING: failed to run ldconfig. this may happen when not installing as root. run with --verbose to see the error rust installed. qemu-ppc64le:~$ echo 'fn main() { println!("hello world"); }' > test.rs qemu-ppc64le:~$ rustc test.rs qemu-ppc64le:~$ ./test hello world qemu-ppc64le:~$ file test test: ELF 64-bit LSB executable, 64-bit PowerPC or cisco 7500, OpenPOWER ELF V2 ABI, version 1 (SYSV), statically linked, BuildID[sha1]=596ee6abf9add487ebc54fb71c2076fb6faea013, with debug_info, not stripped ``` try-job: dist-powerpc64le-linux

bors · 2024-12-03T17:43:52Z

⌛ Trying commit 2b637c6 with merge 31943ab...

src/doc/rustc/src/platform-support/powerpc64le-unknown-linux-musl.md

jieyouxu · 2024-12-03T19:24:46Z

r? jieyouxu

jieyouxu

Thanks. The bootstrap bits look fine to me (r=me for bootstrap bits and a second on the compiler changes), I'll hand this off to T-infra to look at the CI changes.

jieyouxu · 2024-12-03T20:22:59Z

r? infra

Gelbpunkt · 2024-12-03T22:24:32Z

The build looks like it got stuck at some point

jieyouxu · 2024-12-03T22:28:59Z

Build failure is unrelated.

jieyouxu · 2024-12-09T04:46:38Z

CI no space issue, prob @Mark-Simulacrum or someone on @rust-lang/infra can take a look

Kobzol · 2024-12-09T07:53:44Z

We will probably need to use a large runner for this to work. I will bring it up on today's infra meeting.

Kobzol · 2024-12-09T15:18:48Z

Could you please move the CI job to job-linux-4c-largedisk in jobs.yml? Then we'll evaluate how long it takes.

Signed-off-by: Jens Reidel <adrian@travitia.xyz>

Gelbpunkt · 2024-12-09T16:06:22Z

Could you please move the CI job to job-linux-4c-largedisk in jobs.yml? Then we'll evaluate how long it takes.

Done :)

Kobzol · 2024-12-09T16:07:21Z

@bors try

…musl-tier-2, r=<try> Promote powerpc64le-unknown-linux-musl to tier 2 with host tools MCP: rust-lang/compiler-team#803 I'm using crosstool-ng for building a toolchain because GCC 9 from `musl-toolchain.sh` has float ABI issues (?) and can't compile LLVM, and writing a crosstool-ng config for a target feels less hacky than yet another target specific shell script. I also defined a kernel version, since there wasn't one specified before. If a lower version is desired, just let me know. I also tried to match the rust configure args with the loongarch64 musl tier 2 target. The resulting compiler works fine, built with `DEPLOY=1 ./src/ci/docker/run.sh dist-powerpc64le-linux` and tested on Alpine Linux in a VM and on a bare metal POWER8 machine: ``` qemu-ppc64le:/tmp/rust-nightly-powerpc64le-unknown-linux-musl$ ash install.sh install: creating uninstall script at /usr/local/lib/rustlib/uninstall.sh install: installing component 'rustc' install: installing component 'rust-std-powerpc64le-unknown-linux-musl' install: installing component 'cargo' install: installing component 'rustfmt-preview' install: installing component 'rls-preview' install: installing component 'rust-analyzer-preview' install: installing component 'llvm-tools-preview' install: installing component 'clippy-preview' install: installing component 'miri-preview' install: installing component 'rust-analysis-powerpc64le-unknown-linux-musl' install: installing component 'llvm-bitcode-linker-preview' install: WARNING: failed to run ldconfig. this may happen when not installing as root. run with --verbose to see the error rust installed. qemu-ppc64le:~$ echo 'fn main() { println!("hello world"); }' > test.rs qemu-ppc64le:~$ rustc test.rs qemu-ppc64le:~$ ./test hello world qemu-ppc64le:~$ file test test: ELF 64-bit LSB executable, 64-bit PowerPC or cisco 7500, OpenPOWER ELF V2 ABI, version 1 (SYSV), statically linked, BuildID[sha1]=596ee6abf9add487ebc54fb71c2076fb6faea013, with debug_info, not stripped ``` try-job: dist-powerpc64le-linux

bors · 2024-12-09T16:08:33Z

⌛ Trying commit 286de9f with merge ad080db...

bors · 2024-12-09T18:39:01Z

☀️ Try build successful - checks-actions
Build commit: ad080db (ad080db1a019cf7044dfb75863d11b11aaa5e6b8)

Kobzol · 2024-12-09T19:27:58Z

@bors try

…musl-tier-2, r=<try> Promote powerpc64le-unknown-linux-musl to tier 2 with host tools MCP: rust-lang/compiler-team#803 I'm using crosstool-ng for building a toolchain because GCC 9 from `musl-toolchain.sh` has float ABI issues (?) and can't compile LLVM, and writing a crosstool-ng config for a target feels less hacky than yet another target specific shell script. I also defined a kernel version, since there wasn't one specified before. If a lower version is desired, just let me know. I also tried to match the rust configure args with the loongarch64 musl tier 2 target. The resulting compiler works fine, built with `DEPLOY=1 ./src/ci/docker/run.sh dist-powerpc64le-linux` and tested on Alpine Linux in a VM and on a bare metal POWER8 machine: ``` qemu-ppc64le:/tmp/rust-nightly-powerpc64le-unknown-linux-musl$ ash install.sh install: creating uninstall script at /usr/local/lib/rustlib/uninstall.sh install: installing component 'rustc' install: installing component 'rust-std-powerpc64le-unknown-linux-musl' install: installing component 'cargo' install: installing component 'rustfmt-preview' install: installing component 'rls-preview' install: installing component 'rust-analyzer-preview' install: installing component 'llvm-tools-preview' install: installing component 'clippy-preview' install: installing component 'miri-preview' install: installing component 'rust-analysis-powerpc64le-unknown-linux-musl' install: installing component 'llvm-bitcode-linker-preview' install: WARNING: failed to run ldconfig. this may happen when not installing as root. run with --verbose to see the error rust installed. qemu-ppc64le:~$ echo 'fn main() { println!("hello world"); }' > test.rs qemu-ppc64le:~$ rustc test.rs qemu-ppc64le:~$ ./test hello world qemu-ppc64le:~$ file test test: ELF 64-bit LSB executable, 64-bit PowerPC or cisco 7500, OpenPOWER ELF V2 ABI, version 1 (SYSV), statically linked, BuildID[sha1]=596ee6abf9add487ebc54fb71c2076fb6faea013, with debug_info, not stripped ``` try-job: dist-powerpc64le-linux

bors · 2024-12-09T19:29:09Z

⌛ Trying commit 286de9f with merge 6ebd309...

bors · 2024-12-09T22:00:24Z

☀️ Try build successful - checks-actions
Build commit: 6ebd309 (6ebd3096e3613f0bdb88f036367c69b080de1406)

Kobzol · 2024-12-09T22:26:16Z

It's on the slower side, but ~2h 30m is acceptable given our current CI budget.

Gelbpunkt · 2024-12-10T14:15:42Z

I'm assuming the waiting on author label is left here by mistake.

@rustbot label -S-waiting-on-author +S-waiting-on-review

Kobzol · 2024-12-16T10:53:04Z

No infra objections were raised on Zulip, so approving.

@bors r=jieyouxu,Urgau,Kobzol

bors · 2024-12-16T10:53:07Z

📌 Commit 286de9f has been approved by jieyouxu,Urgau,Kobzol

It is now in the queue for this repository.

…x-musl-tier-2, r=jieyouxu,Urgau,Kobzol Promote powerpc64le-unknown-linux-musl to tier 2 with host tools MCP: rust-lang/compiler-team#803 I'm using crosstool-ng for building a toolchain because GCC 9 from `musl-toolchain.sh` has float ABI issues (?) and can't compile LLVM, and writing a crosstool-ng config for a target feels less hacky than yet another target specific shell script. I also defined a kernel version, since there wasn't one specified before. If a lower version is desired, just let me know. I also tried to match the rust configure args with the loongarch64 musl tier 2 target. The resulting compiler works fine, built with `DEPLOY=1 ./src/ci/docker/run.sh dist-powerpc64le-linux` and tested on Alpine Linux in a VM and on a bare metal POWER8 machine: ``` qemu-ppc64le:/tmp/rust-nightly-powerpc64le-unknown-linux-musl$ ash install.sh install: creating uninstall script at /usr/local/lib/rustlib/uninstall.sh install: installing component 'rustc' install: installing component 'rust-std-powerpc64le-unknown-linux-musl' install: installing component 'cargo' install: installing component 'rustfmt-preview' install: installing component 'rls-preview' install: installing component 'rust-analyzer-preview' install: installing component 'llvm-tools-preview' install: installing component 'clippy-preview' install: installing component 'miri-preview' install: installing component 'rust-analysis-powerpc64le-unknown-linux-musl' install: installing component 'llvm-bitcode-linker-preview' install: WARNING: failed to run ldconfig. this may happen when not installing as root. run with --verbose to see the error rust installed. qemu-ppc64le:~$ echo 'fn main() { println!("hello world"); }' > test.rs qemu-ppc64le:~$ rustc test.rs qemu-ppc64le:~$ ./test hello world qemu-ppc64le:~$ file test test: ELF 64-bit LSB executable, 64-bit PowerPC or cisco 7500, OpenPOWER ELF V2 ABI, version 1 (SYSV), statically linked, BuildID[sha1]=596ee6abf9add487ebc54fb71c2076fb6faea013, with debug_info, not stripped ``` try-job: dist-powerpc64le-linux

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#133265 (Add a range argument to vec.extract_if) - rust-lang#133801 (Promote powerpc64le-unknown-linux-musl to tier 2 with host tools) - rust-lang#134323 (coverage: Dismantle `map_data.rs` by moving its responsibilities elsewhere) - rust-lang#134378 (An octuple of polonius fact generation cleanups) - rust-lang#134408 (Regression test for RPIT inheriting lifetime from projection) - rust-lang#134423 (bootstrap: use specific-purpose ui test path for `test_valid` self-test) - rust-lang#134426 (Fix typo in uint_macros.rs) Failed merges: - rust-lang#133103 (Pass FnAbi to find_mir_or_eval_fn) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned ehuss Dec 3, 2024

This comment has been minimized.

Sign in to view

Gelbpunkt force-pushed the powerpc64le-unknown-linux-musl-tier-2 branch from b593b82 to a395c38 Compare December 3, 2024 16:05

ehuss reviewed Dec 3, 2024

View reviewed changes

src/doc/rustc/src/platform-support/powerpc64le-unknown-linux-musl.md Show resolved Hide resolved

rustbot assigned petrochenkov and unassigned ehuss Dec 3, 2024

rustbot assigned albertlarsan68 and unassigned petrochenkov Dec 3, 2024

famfo reviewed Dec 3, 2024

View reviewed changes

src/doc/rustc/src/platform-support/powerpc64le-unknown-linux-musl.md Outdated Show resolved Hide resolved

rustbot assigned jieyouxu and unassigned albertlarsan68 Dec 3, 2024

jieyouxu approved these changes Dec 3, 2024

View reviewed changes

rustbot assigned Mark-Simulacrum and unassigned jieyouxu Dec 3, 2024

This comment was marked as off-topic.

Sign in to view

Move dist-powerpc64le-linux to job-linux-4c-largedisk

286de9f

Signed-off-by: Jens Reidel <adrian@travitia.xyz>

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 10, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 16, 2024

jieyouxu mentioned this pull request Dec 17, 2024

Rollup of 9 pull requests #134430

Closed

jieyouxu mentioned this pull request Dec 17, 2024

Rollup of 8 pull requests #134431

Closed

matthiaskrgr mentioned this pull request Dec 17, 2024

Rollup of 7 pull requests #134439

Merged

bors merged commit ca5dfa7 into rust-lang:master Dec 18, 2024
7 checks passed

rustbot added this to the 1.85.0 milestone Dec 18, 2024

Gelbpunkt deleted the powerpc64le-unknown-linux-musl-tier-2 branch December 18, 2024 11:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Promote powerpc64le-unknown-linux-musl to tier 2 with host tools #133801

Promote powerpc64le-unknown-linux-musl to tier 2 with host tools #133801

Gelbpunkt commented Dec 3, 2024 •

edited by Urgau

Loading

rustbot commented Dec 3, 2024

This comment has been minimized.

rustbot commented Dec 3, 2024

ehuss commented Dec 3, 2024

Urgau commented Dec 3, 2024

bors commented Dec 3, 2024

jieyouxu commented Dec 3, 2024

jieyouxu left a comment •

edited

Loading

jieyouxu commented Dec 3, 2024

This comment was marked as off-topic.

Gelbpunkt commented Dec 3, 2024

jieyouxu commented Dec 3, 2024

jieyouxu commented Dec 9, 2024 •

edited

Loading

Kobzol commented Dec 9, 2024

Kobzol commented Dec 9, 2024

Gelbpunkt commented Dec 9, 2024

Kobzol commented Dec 9, 2024

bors commented Dec 9, 2024

bors commented Dec 9, 2024

Kobzol commented Dec 9, 2024

bors commented Dec 9, 2024

bors commented Dec 9, 2024

Kobzol commented Dec 9, 2024

Gelbpunkt commented Dec 10, 2024

Kobzol commented Dec 16, 2024

bors commented Dec 16, 2024

Promote powerpc64le-unknown-linux-musl to tier 2 with host tools #133801

Promote powerpc64le-unknown-linux-musl to tier 2 with host tools #133801

Conversation

Gelbpunkt commented Dec 3, 2024 • edited by Urgau Loading

rustbot commented Dec 3, 2024

This comment has been minimized.

rustbot commented Dec 3, 2024

ehuss commented Dec 3, 2024

Urgau commented Dec 3, 2024

bors commented Dec 3, 2024

jieyouxu commented Dec 3, 2024

jieyouxu left a comment • edited Loading

Choose a reason for hiding this comment

jieyouxu commented Dec 3, 2024

This comment was marked as off-topic.

Gelbpunkt commented Dec 3, 2024

jieyouxu commented Dec 3, 2024

jieyouxu commented Dec 9, 2024 • edited Loading

Kobzol commented Dec 9, 2024

Kobzol commented Dec 9, 2024

Gelbpunkt commented Dec 9, 2024

Kobzol commented Dec 9, 2024

bors commented Dec 9, 2024

bors commented Dec 9, 2024

Kobzol commented Dec 9, 2024

bors commented Dec 9, 2024

bors commented Dec 9, 2024

Kobzol commented Dec 9, 2024

Gelbpunkt commented Dec 10, 2024

Kobzol commented Dec 16, 2024

bors commented Dec 16, 2024

Gelbpunkt commented Dec 3, 2024 •

edited by Urgau

Loading

jieyouxu left a comment •

edited

Loading

jieyouxu commented Dec 9, 2024 •

edited

Loading