show abi_unsupported_vector_types lint in future breakage reports #133374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nnethercote rustbot has assigned @nnethercote. Use |
rustbot
added
S-waiting-on-review
jieyouxu
added
the
L-abi_unsupported_vector_types
jieyouxu
approved these changes
Nov 23, 2024
jieyouxu
added
the
A-lints
|
r? jieyouxu |
bors
added
S-waiting-on-bors
|
Tagging this w/ compat relnotes, but it's not expected for anyone to really hit this (if they do, good!) @rustbot label +relnotes |
rustbot
added
the
relnotes
3 tasks
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this pull request
Nov 23, 2024
…pes, r=jieyouxu show abi_unsupported_vector_types lint in future breakage reports The lint is now riding the train to 1.84. Given that crater found no case of this lint triggering at all, IMO it's fine to make it "report in deps" already for 1.85. Part of rust-lang#116558.
This was referenced Nov 23, 2024
Done. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 23, 2024
Rollup of 4 pull requests Successful merges: - rust-lang#133217 ([AIX] Add option -X32_64 to the "strip" command) - rust-lang#133237 (Minimally constify `Add`) - rust-lang#133355 (Add language tests for aggregate types) - rust-lang#133374 (show abi_unsupported_vector_types lint in future breakage reports) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 23, 2024
Rollup merge of rust-lang#133374 - RalfJung:abi_unsupported_vector_types, r=jieyouxu show abi_unsupported_vector_types lint in future breakage reports The lint is now riding the train to 1.84. Given that crater found no case of this lint triggering at all, IMO it's fine to make it "report in deps" already for 1.85. Part of rust-lang#116558.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lint is now riding the train to 1.84. Given that crater found no case of this lint triggering at all, IMO it's fine to make it "report in deps" already for 1.85.
See here for crater result analysis, and here for the full report.
Part of #116558.