Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model lexer doesn't handle ... something? #15881

Closed
emberian opened this issue Jul 21, 2014 · 4 comments
Closed

Model lexer doesn't handle ... something? #15881

emberian opened this issue Jul 21, 2014 · 4 comments

Comments

@emberian
Copy link
Member

Tracking issue for the lexer test failing test/run-pass/issue-2185.rs
@emberian emberian mentioned this issue Jul 21, 2014
Closed
7 tasks
@fhahn
Copy link
Contributor

fhahn commented Jan 14, 2015

This issue seems fixed. DOTDOTDOT is already part of the tokens and since the conflict with float literals was resolved when #15877 was fixed it works now as expected.

Note that test/run-pass/issue-2185.rs does not contain any ... any more, but test/run-pass/match-range.rs does. I used this file for testing.

@emberian
Copy link
Member Author

@fhahn cool! Can you add a run-pass test for this explicitly for the purpose of regression testing this?

@fhahn
Copy link
Contributor

fhahn commented Jan 14, 2015

Should I just create a test which contains a match with a range with a name that refers to this issue?

@emberian
Copy link
Member Author

Yeah.

On Wed, Jan 14, 2015 at 6:07 PM, Florian Hahn notifications@github.com
wrote:

Should I just create a test which contains a match with a range with a
name that refers to this issue?

—
Reply to this email directly or view it on GitHub
#15881 (comment).

http://octayn.net/

@fhahn fhahn mentioned this issue Jan 18, 2015
Merged
bors added a commit that referenced this issue Feb 13, 2015
@bors
Auto merge of #21376 - fhahn:issue-15881-model-lexer-dotdotdot, r=cmr
b8c112f 
This PR adds a dedicated regression test for #15881 as @cmr suggested.
@bors bors closed this as completed in b8efaa6 Feb 14, 2015
bors added a commit to rust-lang-ci/rust that referenced this issue Nov 16, 2023
@bors
Auto merge of rust-lang#15881 - nokazn:docs/fix-vscode-setting-sample…
416e9c8 
…s, r=lnicola

docs: fix VS Code setting samples

Fix invalid JSONC examples (missing double quotes) in VS Code's `settings.json` .
Thank you.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@steveklabnik @fhahn @emberian