Add dedicated testcase for #15881 #21376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @cmr |
| // option. This file may not be copied, modified, or distributed | ||
| // except according to those terms. | ||
| // | ||
| // ignore-lexer-test FIXME |
There was a problem hiding this comment.
this ignore should no longer be here
There was a problem hiding this comment.
Yup, I've removed the line (and updated the copyright notice date)
Also enable an ignored test case, closes rust-lang#15881
fhahn
force-pushed
the
issue-15881-model-lexer-dotdotdot
branch
from
a4cab28 to
b8efaa6
Compare
|
Very well. |
|
Isn't @cmr away because of studies? |
|
I am not sure if this issue is still relavant after the new model parser got merged, as this issue involves the antlr lexer, which is obselete now, I guess? |
|
⌛ Testing commit b8efaa6 with merge 5870f25... |
|
@bors: retry |
|
⌛ Testing commit b8efaa6 with merge 3b9da16... |
|
💔 Test failed - auto-mac-64-nopt-t |
|
@bors: retry |
|
⌛ Testing commit b8efaa6 with merge 95c237a... |
|
💔 Test failed - auto-win-32-opt |
|
@bors: retry |
|
⌛ Testing commit b8efaa6 with merge b8c112f... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a dedicated regression test for #15881 as @cmr suggested.