Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unfeature-gate tuple-indexing, then replace tuple indexing traits / methods accordingly #18006

Closed
thestinger opened this issue Oct 13, 2014 · 5 comments · Fixed by #19677
Closed

unfeature-gate tuple-indexing, then replace tuple indexing traits / methods accordingly #18006

thestinger opened this issue Oct 13, 2014 · 5 comments · Fixed by #19677
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. P-medium Medium priority

Comments

@thestinger
Copy link
Contributor

These traits have been marked #[stable] so this is a backwards compatibility issue, but it will be trivial to replace these.
@thestinger thestinger added A-libs E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels Oct 13, 2014
@alexcrichton
Copy link
Member

Note that as-is today we can't deprecate these traits due to tuple indexing being behind a feature gate. In other words, this issue may want to rather be a simultaneous execution of un-feature-gating and deprecating the tuple traits.

@pnkfelix
Copy link
Member

As @alexcrichton says, with tuple-indexing behind a feature gate, it would be bad to remove the tuple-accessor traits/methods until it has been unfeature-gated.

So we are planning to leave the stable markers on the tuple accessor traits unless/until we presumably unfeature-gate tuple-index at some hypothetical point in the future.

@pnkfelix pnkfelix changed the title tuple indexing traits / methods should be replaced with tuple indexing unfeature-gate tuple-indexing, then replace tuple indexing traits / methods accordingly Oct 16, 2014
@pnkfelix
Copy link
Member

P-high

@pnkfelix pnkfelix added P-medium Medium priority and removed I-nominated labels Oct 16, 2014
@pnkfelix pnkfelix mentioned this issue Oct 20, 2014
Closed
@orium
Copy link
Member

orium commented Nov 26, 2014

Does the community have consensus on making tuple_indenxing accepted (i.e. ungated)? I have seen the RFC but found no info about that.

@orium
Copy link
Member

orium commented Nov 27, 2014

Ok, I just found out about this RFC 450 which ask to un-gate tuple indexing, thus blocking this issue.

@japaric japaric mentioned this issue Dec 9, 2014
Merged
bors added a commit that referenced this issue Dec 14, 2014
@bors
auto merge of #19677 : japaric/rust/deprecate-tupleN, r=alexcrichton
5112c41 
r? @alexcrichton or anyone else
closes #18006
bors added a commit that referenced this issue Dec 14, 2014
@bors
auto merge of #19677 : japaric/rust/deprecate-tupleN, r=alexcrichton
10ac5b7 
r? @alexcrichton or anyone else
closes #18006
lnicola pushed a commit to lnicola/rust that referenced this issue Sep 25, 2024
@bors
Auto merge of rust-lang#18006 - ChayimFriedman2:hide-deprecated, r=Ve…
20ed8ce 
…ykril

Provide an option to hide deprecated items from completion

Fixes rust-lang#17989.

I wonder if this should be instead done in the editor, that will do it in a language-agnostic way. Can't hurt to do it in rust-analyzer, I guess.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. P-medium Medium priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate the TupleN traits, and stop using them internally japaric/rust
4 participants
@alexcrichton @pnkfelix @thestinger @orium