Deprecate the TupleN traits, and stop using them internally
#19677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,6 +24,7 @@ | |||
| #![allow(unknown_features)] | |||
| #![feature(macro_rules, default_type_params, phase, globs)] | |||
| #![feature(unsafe_destructor, import_shadowing, slicing_syntax)] | |||
| #![feature(tuple_indexing)] | |||
There was a problem hiding this comment.
I thought tuple_indexing was un-feature-gated, wans't it?
There was a problem hiding this comment.
It was, but the un-feature-gating hasn’t made it into a snapshot yet, so the compiler won’t bootstrap without that.
There was a problem hiding this comment.
Yes in master, but it's still feature gated in the current stage-0 snapshot.
|
Awesome work @japaric, thanks! |
japaric
force-pushed
the
deprecate-tupleN
branch
from
ecf85f3
to
22f0cae
Compare
|
@alexcrichton Addressed your comment. r? |
|
Needs a rebase |
japaric
force-pushed
the
deprecate-tupleN
branch
from
22f0cae
to
8b2f65c
Compare
|
@alexcrichton Rebased, and removed the feature gates I previously added. re-r? |
japaric
force-pushed
the
deprecate-tupleN
branch
from
8b2f65c
to
efd9f23
Compare
|
Argh windows! y u no pass?! @alexcrichton I think I removed all our usages of |
added 13 commits
December 13, 2014 20:04
japaric
force-pushed
the
deprecate-tupleN
branch
from
efd9f23
to
029789b
Compare
bors
added a commit
that referenced
this pull request
Dec 14, 2014
r? @alexcrichton or anyone else closes #18006
bors
added a commit
that referenced
this pull request
Dec 14, 2014
r? @alexcrichton or anyone else closes #18006
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @alexcrichton or anyone else
closes #18006