-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
are feature gates for tuple indexing and slicing properly enforced? #18180
Comments
Note that I demonstrated running both the release (0.12) and a recent development (4480caf) build of rustc on the file that is using these features without the gate. |
#18102 ? |
oh... right. |
(closing as duplicate of #18102 ) |
lnicola
pushed a commit
to lnicola/rust
that referenced
this issue
Oct 8, 2024
feat: Index workspace symbols at startup rather than on the first symbol search. This will eliminate potential many-second delays when performing the first search, at the price of making cache priming (“Indexing N/M” in the VS Code status bar) take a little longer in total. Hopefully this additional time is insignificant because a typical session will involve at least one symbol search. Further improvement would be to do this as a separate parallel task (which will be beneficial if the workspace contains a small number of large crates), but that would require significant additional refactoring of the progress-reporting mechanism to understand multiple tasks per crate. Happy to tackle that in this PR if desired, but I thought I'd propose the minimal change first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have seen evidence that both tuple indexing and slicing syntax are silently allowed by
rustc
, rather than requiring the feature gate turned on to enable them.It could be that I missed some step along the way where these features were officially enabled. But I think its more likely that someone has accidentally turned them both on somehow, especially since the team discussion from last Thursday on #18006 included statements that tuple-indexing is meant to be feature gated.
The text was updated successfully, but these errors were encountered: