Skip to content

Remove #![feature()] for if_let, while_let, and tuple_indexing #19473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nrc opened this issue Dec 2, 2014 · 7 comments · Fixed by #19763
Closed

Remove #![feature()] for if_let, while_let, and tuple_indexing #19473

nrc opened this issue Dec 2, 2014 · 7 comments · Fixed by #19763
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@nrc
Copy link
Member

nrc commented Dec 2, 2014

Needs a snapshot after #19472 lands
@nrc nrc added the E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. label Dec 2, 2014
@abonander
Copy link
Contributor

Looks like most of the work has been done in #19517

@csouth3
Copy link
Contributor

csouth3 commented Dec 4, 2014

Ah, yep. Didn't even see this issue! After #19472 makes it into a snapshot, my PR should close this issue. I'll make double sure before then that I'm getting all of them.

@csouth3 csouth3 mentioned this issue Dec 4, 2014
Closed
@csouth3 csouth3 mentioned this issue Dec 12, 2014
Merged
@mdinger
Copy link
Contributor

mdinger commented Dec 12, 2014

You'll want to remove them from the list of compiler features as well

@csouth3
Copy link
Contributor

csouth3 commented Dec 12, 2014

Pull request has been updated, thanks!

brson added a commit to brson/rust that referenced this issue Dec 12, 2014
@brson
rollup merge of rust-lang#19763: csouth3/remove-featuregates
e3638d3 
This is a revival of rust-lang#19517 (per request of @alexcrichton) now that the new snapshots have landed.  We can now remove the last feature gates for if_let, while_let, and tuple_indexing scattered throughout the test sources since these features have been added to Rust.

Closes rust-lang#19473.
brson added a commit to brson/rust that referenced this issue Dec 13, 2014
@brson
rollup merge of rust-lang#19763: csouth3/remove-featuregates
a2bf4de 
This is a revival of rust-lang#19517 (per request of @alexcrichton) now that the new snapshots have landed.  We can now remove the last feature gates for if_let, while_let, and tuple_indexing scattered throughout the test sources since these features have been added to Rust.

Closes rust-lang#19473.
@lgrz
Copy link
Contributor

lgrz commented Dec 15, 2014

These feature gates (if_let, tuple_indexing) look liked they were left in, they're supposed to be removed right?

https://github.com/rust-lang/rust/blob/master/src/libcollections/lib.rs#L27
https://github.com/rust-lang/rust/blob/master/src/librustc_borrowck/lib.rs#L19-L20

@csouth3
Copy link
Contributor

csouth3 commented Dec 15, 2014

Oops, looks like the two in borrowck were added after my PR was r+'ed and I didn't see them. I'd be happy to go take them out, but it looks like #19741 actually takes care of these last three as part of the second commit, so it may potentially be better to just wait for that to land so I don't get in the way of it.

@lgrz
Copy link
Contributor

lgrz commented Dec 15, 2014

Ah thanks, I wasn't aware they were already taken care of.

brson added a commit to brson/rust that referenced this issue Dec 15, 2014
@brson
rollup merge of rust-lang#19763: csouth3/remove-featuregates
e717362 
This is a revival of rust-lang#19517 (per request of @alexcrichton) now that the new snapshots have landed.  We can now remove the last feature gates for if_let, while_let, and tuple_indexing scattered throughout the test sources since these features have been added to Rust.

Closes rust-lang#19473.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
5 participants
@lgrz @nrc @abonander @mdinger @csouth3