Skip to content

Remove feature gate directives for if_let, while_let, and tuple_indexing. #19763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2014

Conversation

csouth3
Copy link
Contributor

@csouth3 csouth3 commented Dec 12, 2014

This is a revival of #19517 (per request of @alexcrichton) now that the new snapshots have landed. We can now remove the last feature gates for if_let, while_let, and tuple_indexing scattered throughout the test sources since these features have been added to Rust.

Closes #19473.

@steveklabnik
Copy link
Member

Woooo

Sent from my iPhone

On Dec 11, 2014, at 21:18, Chase Southwood notifications@github.com wrote:

This is a revival of #19517 (per request of @alexcrichton) now that the new snapshots have landed. We can now remove the last feature gates for if_let, while_let, and tuple_indexing scattered throughout the test sources since these features have been added to Rust.

Closes #19473.

You can merge this Pull Request by running

git pull https://github.com/csouth3/rust remove-featuregates
Or view, comment on, or merge it at:

#19763

Commit Summary

Remove feature gate directives for if_let, while_let, and tuple_indexing.
File Changes

M src/test/compile-fail/issue-19096.rs (2)
M src/test/run-pass/borrow-tuple-fields.rs (2)
M src/test/run-pass/if-let.rs (2)
M src/test/run-pass/issue-18412.rs (2)
M src/test/run-pass/issue-19244.rs (2)
M src/test/run-pass/issue-19367.rs (1)
M src/test/run-pass/tuple-index-fat-types.rs (2)
M src/test/run-pass/tuple-index.rs (2)
M src/test/run-pass/while-let.rs (2)
Patch Links:

https://github.com/rust-lang/rust/pull/19763.patch
https://github.com/rust-lang/rust/pull/19763.diff

Reply to this email directly or view it on GitHub.

@csouth3 csouth3 force-pushed the remove-featuregates branch from 19cf8cb to cd3bdeb Compare December 12, 2014 19:24
@csouth3
Copy link
Contributor Author

csouth3 commented Dec 12, 2014

Per @mdinger at #19473, I forgot to remove these from the list of compiler features in the reference!
I've updated the pull request to remove them from that list now. @sfackler re-r?

brson added a commit to brson/rust that referenced this pull request Dec 12, 2014
This is a revival of rust-lang#19517 (per request of @alexcrichton) now that the new snapshots have landed.  We can now remove the last feature gates for if_let, while_let, and tuple_indexing scattered throughout the test sources since these features have been added to Rust.

Closes rust-lang#19473.
brson added a commit to brson/rust that referenced this pull request Dec 13, 2014
This is a revival of rust-lang#19517 (per request of @alexcrichton) now that the new snapshots have landed.  We can now remove the last feature gates for if_let, while_let, and tuple_indexing scattered throughout the test sources since these features have been added to Rust.

Closes rust-lang#19473.
bors added a commit that referenced this pull request Dec 14, 2014
Remove feature gate directives for `if_let`, `while_let`, and `tuple_indexing`.

Reviewed-by: sfackler
@Gankra
Copy link
Contributor

Gankra commented Dec 15, 2014

@csouth3 There's more gates. Dunno if they slipped in or what. CC #19881 and #19876

brson added a commit to brson/rust that referenced this pull request Dec 15, 2014
This is a revival of rust-lang#19517 (per request of @alexcrichton) now that the new snapshots have landed.  We can now remove the last feature gates for if_let, while_let, and tuple_indexing scattered throughout the test sources since these features have been added to Rust.

Closes rust-lang#19473.
@csouth3
Copy link
Contributor Author

csouth3 commented Dec 15, 2014

Yeah, I know for sure that the ones in borrowck must have been added after this was r+ed since borrowck wasn't even a crate when I originally opened this...oops! Looks like there's an approved PR in the queue now to get the last 3 though.

@bors bors merged commit cd3bdeb into rust-lang:master Dec 15, 2014
@csouth3 csouth3 deleted the remove-featuregates branch December 16, 2014 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove #![feature()] for if_let, while_let, and tuple_indexing
5 participants