-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advertise impls of out-of-create traits for third party types with some type parameters set to in-crate types in rustdoc #25264
Comments
Just wanted to add in, this would be useful for rust-gnome as well, because we're starting to have a few cross-crate trait impls, and, as of now, have no easy way of documenting them. |
Triage: no change. Given that this is an open set of things, I'm not sure it's something that can ever really be done... |
Just to clarify this: You want to be able to show a trait implementation when one of its type parameters is a local type? i.e. |
Because of the coherence rules, impls can only be defined in one place depending on the types they reference. That's the place they should be documented as well. |
#42440 was labelled C-bug but this is labelled C-enhancement |
I'll swap the labels, since this is a shortcoming of the generated docs. |
I've opened #44969 to fix this. |
…bnik document trait impls when the type appears in the trait's generics Fixes #25264 ![image](https://user-images.githubusercontent.com/5217170/31062309-4fc7c594-a6ef-11e7-892e-07f95bbc7976.png)
As an example, in iron, the impls of
Modifier<Response>
for std types likeString
,File
, andPath
are not advertised anywhere in the generated documentation.The text was updated successfully, but these errors were encountered: