Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document trait impls when the type appears in the trait's generics #44969

Merged
merged 1 commit into from
Oct 12, 2017
Merged

document trait impls when the type appears in the trait's generics #44969

merged 1 commit into from
Oct 12, 2017

Conversation

QuietMisdreavus
Copy link
Member

Fixes #25264

image

@rust-highfive
Copy link
Collaborator

r? @steveklabnik

(rust_highfive has picked a reviewer for you, use r? to override)

@QuietMisdreavus QuietMisdreavus mentioned this pull request Oct 2, 2017
Closed
@carols10cents carols10cents added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 2, 2017
@steveklabnik
Copy link
Member

Iiinteresting. I like it, would like to see what others say.

@QuietMisdreavus
Copy link
Member Author

I guess we should properly tag @rust-lang/docs to pull in the others, in that case.

@GuillaumeGomez
Copy link
Member

Wo, that's awesome! Huge 👍 for me!

@steveklabnik
Copy link
Member

@bors: r+

everyone is happy with this!

@bors
Copy link
Contributor

bors commented Oct 11, 2017

📌 Commit 23f5fbe has been approved by steveklabnik

@bors
Copy link
Contributor

bors commented Oct 12, 2017

⌛ Testing commit 23f5fbe with merge fbb5054...

bors added a commit that referenced this pull request Oct 12, 2017
@bors
Auto merge of #44969 - QuietMisdreavus:impls-for-everyone, r=stevekla…
fbb5054 
…bnik

document trait impls when the type appears in the trait's generics

Fixes #25264

![image](https://user-images.githubusercontent.com/5217170/31062309-4fc7c594-a6ef-11e7-892e-07f95bbc7976.png)
@bors
Copy link
Contributor

bors commented Oct 12, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: steveklabnik
Pushing fbb5054 to master...

@bors bors merged commit 23f5fbe into rust-lang:master Oct 12, 2017
@ollie27 ollie27 mentioned this pull request Oct 29, 2017
Closed
@QuietMisdreavus QuietMisdreavus deleted the impls-for-everyone branch February 26, 2018 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@QuietMisdreavus @rust-highfive @steveklabnik @GuillaumeGomez @bors @carols10cents