-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stack overflow in rustdoc using enum_primitive with a big enum #25295
Comments
This seems to be fixed. |
In my tests, you now need to have around 460+ enum variants in order to get the stack overflow. Can we assume nobody will ever have that many? |
@alexcrichton: should a test still be written for this? |
In theory yeah if there's something that overflowed previously and no longer does, we should have a test for that :) |
Triage: not aware of a test yet |
test that rustdoc doesn't overflow on a big enum Adds a test to close rust-lang#25295. The test case depended on `enum_primitive` so I just basically pulled its source into an auxiliary file, is that the right way to do it?
Running
cargo doc
on the following code results in a stack overflow:With significantly fewer enum variants, it works. If I remove the use of
enum_from_primitive!
, it works.This is breaking
cargo doc
on one of my PRs (PistonDevelopers/glfw-rs#316).The text was updated successfully, but these errors were encountered: