Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Un-xfail or remove src/test/run-pass/foreign-lib-path.rs #2604

Closed
catamorphism opened this issue Jun 14, 2012 · 6 comments · Fixed by #12457
Closed

Un-xfail or remove src/test/run-pass/foreign-lib-path.rs #2604

catamorphism opened this issue Jun 14, 2012 · 6 comments · Fixed by #12457
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc P-low Low priority

Comments

@catamorphism
Copy link
Contributor

(Originally titled: "Un-xfail or remove test/run-pass/native-lib-path.rs")

What the title says.
@z0w0
Copy link
Contributor

z0w0 commented Apr 23, 2013

I can't seem to find this test anymore, so I'm going to assume it was already removed.

@z0w0 z0w0 closed this as completed Apr 23, 2013
@z0w0 z0w0 reopened this Apr 23, 2013
@z0w0 z0w0 closed this as completed Apr 23, 2013
@alexcrichton
Copy link
Member

This appears to have been moved to src/test/run-pass/foreign-lib-path.rs

@alexcrichton alexcrichton reopened this Jun 15, 2013
@bblum
Copy link
Contributor

bblum commented Jun 21, 2013

nominating well-covered milestone

@brson
Copy link
Contributor

brson commented Jun 27, 2013

Some insight into what this test is about: This is a test that we can find and link to foreign libraries with the -L. flag. The test harness has no way to do this currently, but it's a pretty low-priority test (we know this works because there's lots of code in the wild that does it successfully).

@pnkfelix
Copy link
Member

visiting for triage, email from 2013 sep 23.

@pnkfelix
Copy link
Member

accepted for P-low.

@alexcrichton alexcrichton mentioned this issue Feb 22, 2014
Merged
bors added a commit that referenced this issue Feb 25, 2014
@bors
auto merge of #12457 : alexcrichton/rust/fix-some-tests, r=brson
fc1c06d 
This updates a number of ignore-test tests, and removes a few completely
outdated tests due to the feature being tested no longer being supported.

This brings a number of bench/shootout tests up to date so they're compiling
again. I make no claims to the performance of these benchmarks, it's just nice
to not have bitrotted code.

Closes #2604
Closes #9407
RalfJung pushed a commit to RalfJung/rust that referenced this issue Oct 22, 2022
@bors
Auto merge of rust-lang#2604 - RalfJung:ret-scalar, r=RalfJung
4207f9e 
use Scalar return types for Windows shims

I started doing this while working on rust-lang/miri#2595; now I don't need the rest of this patch but this part still makes sense.
Aaron1011 pushed a commit to Aaron1011/rust that referenced this issue Jan 6, 2023
@bors
Auto merge of rust-lang#2604 - RalfJung:ret-scalar, r=RalfJung
4a1ce8a 
use Scalar return types for Windows shims

I started doing this while working on rust-lang/miri#2595; now I don't need the rest of this patch but this part still makes sense.
celinval added a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@celinval
Do not run benchcomp in every PR (rust-lang#2604)
ab32ccc 
The performance benchmark PR is taking a lot of our CI time and many times it's not necessary. For example, benchmark job over 2h while all the other runs ran in less than 40min in this run

This PR moves the performance benchmark to a separate workflow that only runs on pushes to main / release tags and PR's that are labeled with 'Z-BenchCI'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc P-low Low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: Clean out the test suite a bit alexcrichton/rust
6 participants
@alexcrichton @brson @pnkfelix @catamorphism @z0w0 @bblum