Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sched::test::dont_starve_1 deadlocks with valgrind and on bsd #9407

Closed
thestinger opened this issue Sep 22, 2013 · 5 comments · Fixed by #12457
Closed

sched::test::dont_starve_1 deadlocks with valgrind and on bsd #9407

thestinger opened this issue Sep 22, 2013 · 5 comments · Fixed by #12457

Comments

@thestinger
Copy link
Contributor

I think this test only works when you have more than one physical/logical core.
@alexcrichton
Copy link
Member

Relevant commit is c767643
Relevant logs are http://buildbot.rust-lang.org/builders/snap3-mac/builds/372/steps/test/logs/stdio
Relevant test is rt::sched::test::dont_starve_1
Relevant person is @brson

Yay for relativity! or something like that.

@thestinger thestinger mentioned this issue Sep 22, 2013
Merged
@thestinger
Copy link
Contributor Author

http://buildbot.rust-lang.org/builders/snap3-bsd/builds/137/steps/test/logs/stdio

@alexcrichton
Copy link
Member

It was attempted to only run this test when not running on valgrind, but @thestinger noticed that it still failed on bsd, so it was completely removed as a test (the code's still there) in #9412

@brson
Copy link
Contributor

brson commented Sep 25, 2013

This is because the buildbot configuration sets RUST_RT_TEST_THREADS=1 when valgrinding and this test depends on that value being >1.

@thestinger
Copy link
Contributor Author

@brson: any idea why it also deadlocks on the BSD bot? I added a workaround for valgrind but it wasn't enough

@alexcrichton alexcrichton mentioned this issue Feb 22, 2014
Merged
bors added a commit that referenced this issue Feb 25, 2014
@bors
auto merge of #12457 : alexcrichton/rust/fix-some-tests, r=brson
fc1c06d 
This updates a number of ignore-test tests, and removes a few completely
outdated tests due to the feature being tested no longer being supported.

This brings a number of bench/shootout tests up to date so they're compiling
again. I make no claims to the performance of these benchmarks, it's just nice
to not have bitrotted code.

Closes #2604
Closes #9407
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: Clean out the test suite a bit alexcrichton/rust
3 participants
@alexcrichton @brson @thestinger