Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possibly use a vector of nodes to represent rope concat nodes #2744

Closed
catamorphism opened this issue Jun 28, 2012 · 2 comments
Closed

Possibly use a vector of nodes to represent rope concat nodes #2744

catamorphism opened this issue Jun 28, 2012 · 2 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. I-slow Issue: Problems and improvements with respect to performance of generated code.

Comments

@catamorphism
Copy link
Contributor

As per FIXME in std::rope.
@catamorphism
Copy link
Contributor Author

Also: try to refactor code (probably by using classes) to avoid pattern-matching in things like byte_len, and use memcpy in serialize_node. I have a branch that tries to do these things, but I got test failures and probably did something subtly and horribly wrong that I don't want to debug at the moment.

@ghost ghost assigned catamorphism Jul 21, 2012
@thestinger thestinger mentioned this issue Jul 6, 2013
Merged
@emberian
Copy link
Member

emberian commented Jul 7, 2013

Will be closed by #7629

bors added a commit that referenced this issue Jul 7, 2013
@bors
auto merge of #7629 : thestinger/rust/rope, r=graydon
ddf8247 
It's broken/unmaintained and needs to be rewritten to avoid managed
pointers and needless copies. A full rewrite is necessary and the API
will need to be redone so it's not worth keeping this around (#7628).

Closes #2236, #2744
@catamorphism catamorphism removed their assignment Jun 16, 2014
RalfJung pushed a commit to RalfJung/rust that referenced this issue Dec 28, 2022
@bors
Auto merge of rust-lang#2744 - RalfJung:json, r=RalfJung
be3ed4f 
support using a JSON target file

Fixes rust-lang/miri#2053
Aaron1011 pushed a commit to Aaron1011/rust that referenced this issue Jan 6, 2023
@bors
Auto merge of rust-lang#2744 - RalfJung:json, r=RalfJung
61a933f 
support using a JSON target file

Fixes rust-lang/miri#2053
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. I-slow Issue: Problems and improvements with respect to performance of generated code.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@catamorphism @emberian @thestinger