-
Notifications
You must be signed in to change notification settings - Fork 13.3k
ICE: constant expression should not reach expr::trans_def #28104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
I-ICE
Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️
Comments
Closed
sgrif
added a commit
to diesel-rs/diesel
that referenced
this issue
Nov 20, 2015
We were using `*` in quite a few places, which was a really bad idea since we are getting the data by index, not by name. There were two options here: expicitly stating the columns we wanted in the query, or fetching them by name during deserialization. I've opted for the former, as the code that was coming out of the latter was ugly and had major performance implications. While I'm sure I could eventually get the performance where I need it, I didn't like the direction the code was heading, and the interaction between named and ordered parameters. I also started to realize that dealing with overlapping column names, or expressions that aren't columns would require figuring out a consistent aliasing strategy, and committing to it. As I've learned from maintaining AR, that's a path to madness. The `star` type is still useful to keep around for things like count. I've changed it's SQL type to `()`, and removed it from any generic contexts to indicate it shouldn't be used. I haven't decided if I want to leave it where it is yet. The definition of `table::all_columns()` doesn't use the const due to rust-lang/rust#28104
At least since 1.8 this produces a slightly different ice:
|
This ICE seems to be fixed on
I have a hunch that this is due to MIR being turned on, though I'm not sure. Please let me know if this still ICEs for you, but closing for now 🎊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Code that reproduces the ICE:
The text was updated successfully, but these errors were encountered: