Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ICEs to Glacier #29249

Closed
steveklabnik opened this issue Oct 23, 2015 · 36 comments
Closed

Add ICEs to Glacier #29249

steveklabnik opened this issue Oct 23, 2015 · 36 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. metabug Issues about issues themselves ("bugs about bugs")

Comments

@steveklabnik
Copy link
Member

steveklabnik commented Oct 23, 2015

My Glacier repository is tracking our ICEs. Once per day, a Travis build confirms that the example still causes an ICE.

@Manishearth suggested I make a metabug here, so if you're looking for an easy way to contribute, this is it! I'm willing to mentor anyone who needs help.

https://github.com/rust-lang/rust/issues?q=is%3Aopen+is%3Aissue+label%3AI-ICE is the list of bugs. Here's a tracking list of which ones that have been added:

@steveklabnik steveklabnik added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-testsuite Area: The testsuite used to check the correctness of rustc metabug Issues about issues themselves ("bugs about bugs") E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Oct 23, 2015
@bltavares
Copy link
Contributor

I don't know how to reproduce #29249 on CI, as it requires a PII computer apparently.

@Gankra
Copy link
Contributor

Gankra commented Oct 23, 2015

@bltavares you appear to have linked to this issue itself?

@bltavares
Copy link
Contributor

@gankro my bad #14441

@steveklabnik
Copy link
Member Author

@bltavares hmmm, yes, that's a tough one. Maybe it's too much effort, and should just be checked off the list?

@bltavares
Copy link
Contributor

@steveklabnik I think it makes sense to be checked here. What about adding a note to skip certain ICEs on Glacier?

@steveklabnik
Copy link
Member Author

I checked it off and left a note.

@bltavares
Copy link
Contributor

#15522 is a Windows bug and the initial files used to report the issue are not available anymore.

@bltavares
Copy link
Contributor

#18937 Does not produce ICE, but is unsound according to the discussion and would better produce ICE.

@bltavares
Copy link
Contributor

#18953 Is stale and needs test case. Was initially found on Zinc.

@bltavares
Copy link
Contributor

#19497 Has no code to reproduce. Not sure what to do over there.

@bltavares
Copy link
Contributor

#19500 Has no code to reproduce.

@bltavares
Copy link
Contributor

#19635 Has no code to reproduce.

@bltavares
Copy link
Contributor

#19675 has been closed already.

@emoon
Copy link
Contributor

emoon commented Oct 24, 2015

#26886 Doesn't seem to be an issue anymore and is marked with E-needstest

@steveklabnik
Copy link
Member Author

Thank you both for all of your work here! This is great 💯

@bltavares
Copy link
Contributor

@steveklabnik Thanks for showing a simple way to contribute back. (:

@bltavares
Copy link
Contributor

#20767 Is stale and needs a compiling example

@bltavares
Copy link
Contributor

#21275 Is stale and needs an example code

@bltavares
Copy link
Contributor

#21321 The author says it could have been fixed already, but the author is not sure (nor am I)

@bltavares
Copy link
Contributor

#21349 Is stale and needs a small reproducible example.

@wheals
Copy link
Contributor

wheals commented Oct 25, 2015

#21461 was closed as fixed by #26667.

@bltavares
Copy link
Contributor

#24956 has been closed by #29284

@emoon
Copy link
Contributor

emoon commented Oct 28, 2015

This one has been closed #24957

@bltavares
Copy link
Contributor

#24947 No loger ICE

@bltavares
Copy link
Contributor

#23370 has been closed already.

@bltavares
Copy link
Contributor

#23003 has been closed.

@ville-h
Copy link
Contributor

ville-h commented Nov 4, 2015

https://github.com/steveklabnik/glacier/blob/master/src/27954.rs appears to have been added but not marked as such

@tamird
Copy link
Contributor

tamird commented Nov 10, 2015

#24956 is incorrectly marked; this issue was never resolved and is reopened.

@steveklabnik
Copy link
Member Author

whoops! must have messed that up :(

@wldcordeiro
Copy link

I'll take on a couple if someone can mentor, I really want to learn me some more Rust by contributing to Rust. 😄

@steveklabnik
Copy link
Member Author

@wldcordeiro sure thing! Basically, pick one of the unchecked things, find the code that causes the compiler to crash, and then make a PR to steveklabnik/glacier that looks like this: https://github.com/steveklabnik/glacier/blob/master/src/15694.rs

File name is the issue number, and it's just the code. I can help with any questions if you need any of that explained further, or I can help in real time if you drop by IRC.

@steveklabnik
Copy link
Member Author

Thank you! Checked those off the list.

@emoon
Copy link
Contributor

emoon commented Nov 21, 2015

I did a pass on the remaining issues in the list. All of them are non-trivial to add to the current way the tests are being done now and can't be reproduced with a single source file.

So I'm not sure what would be the best way to proceed on the remaining issues without trying to make the testing script a bit more advanced (needs to be able to clone stuff on git, run cargo, or compile with rustc using specific flags to trigger issues in some cases)

@emoon
Copy link
Contributor

emoon commented Jan 16, 2016

Seems that #29052 is closed now

@steveklabnik
Copy link
Member Author

This list is basically done, I think; the remaining ones are not automatable. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. metabug Issues about issues themselves ("bugs about bugs")
Projects
None yet
Development

No branches or pull requests

8 participants