-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explain what an "OS string" is in OsStr/OsString docs #30743
Comments
Actually, the What is the best course of action in these cases? |
This is basically part of #29354 |
Just the most straightforward thing: there's work to be done. Just hasn't been done yet. |
I get that. The question was more like, should the existing text be moved to the structs, or to the module that is exported in the docs? |
Ahh, sorry. So yeah, module-level docs should discuss the module as a whole, the struct docs, just that struct. Checking out that source you found, yeah, even just moving them to be on the struct itself would be a pretty big improvement; maybe let's say that closes this ticket, and then making them awesome is just part of that metabug. Sound good? |
(fixes rust-lang#30743) Not sure if the "Note" should be kept.
Currently, this is pretty bare: http://doc.rust-lang.org/nightly/std/ffi/struct.OsString.html
Needs some explanation what an OS string is, and why it is different from C and Rust strings.
The text was updated successfully, but these errors were encountered: