Skip to content

Conversation

@birkenfeld
Copy link
Contributor

(fixes #30743)

Not sure if the "Note" should be kept.

@rust-highfive
Copy link
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@steveklabnik
Copy link
Contributor

Not sure if the "Note" should be kept.

Yeah, we should take it out. Mind doing that? r=me after, thank you!

@birkenfeld
Copy link
Contributor Author

r? @steveklabnik

@rust-highfive rust-highfive assigned steveklabnik and unassigned aturon Jan 7, 2016
@steveklabnik
Copy link
Contributor

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 7, 2016

📌 Commit cdbf2d6 has been approved by steveklabnik

@birkenfeld
Copy link
Contributor Author

Nice :)

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jan 8, 2016
bors added a commit that referenced this pull request Jan 8, 2016
@bors bors merged commit cdbf2d6 into rust-lang:master Jan 9, 2016
@birkenfeld birkenfeld deleted the fix-30743 branch April 21, 2016 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Explain what an "OS string" is in OsStr/OsString docs

5 participants