-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up atomic primitives in libcore #3124
Labels
C-cleanup
Category: PRs that clean code up or issues documenting cleanup.
Comments
I think ARCs call into the runtime to do atomic operations. Now that we have atomic intrinsics, we can use those instead. I suspect some of the nasty organization in pipes might have been working around compiler bugs, like #3005. The workarounds may not actually be effective though, it could have just been stuff I tried when looking for a workaround that I never removed. |
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this issue
Oct 21, 2023
Fix rounding mode check in SSE4.1 round functions Now it masks out the correct bit and adds some explanatory comments. Also extends the tests.
celinval
pushed a commit
to celinval/rust-dev
that referenced
this issue
Jun 4, 2024
Workflows that run the perf regressions (`scripts/kani-perf.sh`) do not need to build Kani, as the perf script itself builds Kani in release mode: https://github.com/model-checking/kani/blob/dc0978043c52492112e4ad37a617fd3c8100ef1f/scripts/kani-perf.sh#L12 The extra build step was causing Kani to be built two extra times for the `benchcomp` flow because the workflow was building it in debug mode, so the script will end up rebuilding it in release mode. This should save about 3 minutes for the `benchcomp` flow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
nasty organisation in pipes and in arc.
The text was updated successfully, but these errors were encountered: