Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OsString could implement the Default trait #32385

Closed
tomjakubowski opened this issue Mar 21, 2016 · 6 comments
Closed

OsString could implement the Default trait #32385

tomjakubowski opened this issue Mar 21, 2016 · 6 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@tomjakubowski
Copy link
Contributor

std::ffi::OsString has an associated function new() -> OsString, but no Default impl. Probably just an oversight, and so not RFC-worthy IMHO.
@tomjakubowski
Copy link
Contributor Author

Test case: https://play.rust-lang.org/?gist=a0163d89a5fca1bd30d4&version=nightly

@frewsxcv
Copy link
Member

Someone mark this as "good first bug"?

@alexcrichton alexcrichton added A-libs E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. labels Mar 21, 2016
@alexcrichton
Copy link
Member

Indeed!

@bluss
Copy link
Member

bluss commented Mar 21, 2016

The same applies to &OsStr (just do it the same way &str does).

@WiSaGaN
Copy link
Contributor

WiSaGaN commented Mar 21, 2016

I'll take it if no one hasn't already.

@frewsxcv
Copy link
Member

I'll take it if no one hasn't already.

Go for it!

@WiSaGaN WiSaGaN mentioned this issue Mar 21, 2016
Merged
eddyb added a commit to eddyb/rust that referenced this issue Mar 23, 2016
@eddyb
Rollup merge of rust-lang#32404 - WiSaGaN:feature/osstring-implement-…
2de428e 
…default, r=aturon

Implement Default trait for OsString/OsStr

Fixes rust-lang#32385
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@alexcrichton @frewsxcv @tomjakubowski @WiSaGaN @bluss