Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Default trait for OsString/OsStr #32404

Merged
merged 3 commits into from
Mar 23, 2016
Merged

Implement Default trait for OsString/OsStr #32404

merged 3 commits into from
Mar 23, 2016

Conversation

WiSaGaN
Copy link
Contributor

@WiSaGaN WiSaGaN commented Mar 21, 2016

Fixes #32385

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@WiSaGaN
Copy link
Contributor Author

WiSaGaN commented Mar 21, 2016

Hmm, what version attribute should I use?

bluss
bluss reviewed Mar 21, 2016
View reviewed changes
src/libstd/ffi/os_str.rs
@@ -173,6 +173,14 @@ impl ops::Deref for OsString {
}
}

#[stable(feature = "rust1", since = "1.9.0")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a new feature name. For example osstring_default (use same for both). Version 1.9.0 is ok I think since we are still in version 1.9.0 in the nightly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed. Thanks!

@alexcrichton alexcrichton mentioned this pull request Mar 21, 2016
Closed
@WiSaGaN
Copy link
Contributor Author

WiSaGaN commented Mar 22, 2016

r? @alexcrichton

@rust-highfive rust-highfive assigned alexcrichton and unassigned aturon Mar 22, 2016
@aturon
Copy link
Member

aturon commented Mar 22, 2016

Looks good, thanks for the PR!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Mar 22, 2016

📌 Commit b5b1d06 has been approved by aturon

@bors
Copy link
Contributor

bors commented Mar 22, 2016

⌛ Testing commit b5b1d06 with merge 99694f5...

@bors
Copy link
Contributor

bors commented Mar 22, 2016

💔 Test failed - auto-win-gnu-64-opt

@WiSaGaN
Copy link
Contributor Author

WiSaGaN commented Mar 22, 2016

Anything I can do here?

@bluss
Copy link
Member

bluss commented Mar 22, 2016

@bors retry

I don't think so, seems like it didn't have a good reason to not complete.

eddyb added a commit to eddyb/rust that referenced this pull request Mar 23, 2016
@eddyb
Rollup merge of rust-lang#32404 - WiSaGaN:feature/osstring-implement-…
2de428e 
…default, r=aturon

Implement Default trait for OsString/OsStr

Fixes rust-lang#32385
@eddyb eddyb mentioned this pull request Mar 23, 2016
Merged
bors added a commit that referenced this pull request Mar 23, 2016
@bors
Auto merge of #32454 - eddyb:rollup, r=eddyb
98f0a91 
Rollup of 11 pull requests

- Successful merges: #32404, #32420, #32423, #32425, #32429, #32430, #32431, #32434, #32437, #32441, #32443
- Failed merges:
@bors bors merged commit b5b1d06 into rust-lang:master Mar 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@WiSaGaN @rust-highfive @aturon @bors @bluss @alexcrichton