Skip to content

The rust book page on mutability is confusingly worded #33924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jwatt opened this issue May 28, 2016 · 3 comments
Closed

The rust book page on mutability is confusingly worded #33924

jwatt opened this issue May 28, 2016 · 3 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@jwatt
Copy link

jwatt commented May 28, 2016

In the rust book section on mutability the text is written in a very confusing way. I'm particularly thinking of the bits of text like:

when we say something is ‘immutable’ [...] we mean something has ‘exterior mutability’

Perhaps this can be reworded as:

when we say something is ‘immutable’ [...] we mean something has ‘exterior immutability’

Or if the phrase "exterior immutability" isn't acceptable, then a more general rewording like:

when we say something is ‘immutable’ [...] we are referring to its ‘exterior mutability’

Or:

when we say something is ‘immutable’ [...] we mean something has ‘exterior mutability’ that in this case is immutable

As it's currently worded it sounds roughly like saying "when something is immutable it is mutable", since saying that something has "exterior mutability" sounds like saying it is mutable on the exterior.

@steveklabnik steveklabnik added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. E-help-wanted Call for participation: Help is requested to fix this issue. labels Jun 27, 2016
@steveklabnik
Copy link
Member

I would be happy to work with anyone who wants to work on this issue.

steveklabnik added a commit to steveklabnik/rust that referenced this issue Jul 5, 2016
… r=steveklabnik

Clarifies the meaning of the external mutability.
steveklabnik added a commit to steveklabnik/rust that referenced this issue Jul 5, 2016
… r=steveklabnik

Clarifies the meaning of the external mutability.
steveklabnik added a commit to steveklabnik/rust that referenced this issue Jul 6, 2016
… r=steveklabnik

Clarifies the meaning of the external mutability.
@GuillaumeRochat
Copy link
Contributor

@steveklabnik I think this issue can be closed since #34621

@steveklabnik
Copy link
Member

Great! Thanks 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Development

No branches or pull requests

3 participants