-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarifies the meaning of the external mutability. #34621
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@steveklabnik It fixes #33924 using the last suggestion from @jwatt. Is it clear enough this way? Hopefully I'm doing it the right way. Thanks! |
@@ -62,8 +62,8 @@ Note that here, the `x` is mutable, but not the `y`. | |||
# Interior vs. Exterior Mutability | |||
|
|||
However, when we say something is ‘immutable’ in Rust, that doesn’t mean that | |||
it’s not able to be changed: we mean something has ‘exterior mutability’. Consider, | |||
for example, [`Arc<T>`][arc]: | |||
it’s not able to be changed: we are referring to it's ‘exterior mutability’ that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the apostrophe it's
should be its
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops! Thanks for catching it!
@KaivoAnastetiks thank you! Looks good. @bors: r+ rollup |
📌 Commit 6a85183 has been approved by |
… r=steveklabnik Clarifies the meaning of the external mutability.
… r=steveklabnik Clarifies the meaning of the external mutability.
… r=steveklabnik Clarifies the meaning of the external mutability.
No description provided.