Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustbuild: propagate bootstrap.py '--help' flag #34558

Merged
merged 1 commit into from
Jul 7, 2016
Merged

Conversation

GlenDC
Copy link
Contributor

@GlenDC GlenDC commented Jun 29, 2016

Fixes #34534.
r? @alexcrichton

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+ 3f6c38c

Thanks!

@sophiajt
Copy link
Contributor

sophiajt commented Jul 5, 2016

@alexcrichton - I don't see this in the queue. Not sure why. Might also be worth making this rollup...

@GuillaumeGomez
Copy link
Member

@jonathandturner: I agree and strange, it doesn't seem to be in the queue...

@bors: r+ rollup

@GuillaumeGomez
Copy link
Member

Something really strange is happening here...

@alexcrichton alexcrichton reopened this Jul 5, 2016
@alexcrichton
Copy link
Member

Looks like something got out of sync and bors dropped this one by accident, looks to be in the queue now though, sorry about that @GlenDC!

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jul 5, 2016
rustbuild: propagate bootstrap.py '--help' flag

Fixes rust-lang#34534.
r? @alexcrichton
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jul 5, 2016
rustbuild: propagate bootstrap.py '--help' flag

Fixes rust-lang#34534.
r? @alexcrichton
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jul 6, 2016
rustbuild: propagate bootstrap.py '--help' flag

Fixes rust-lang#34534.
r? @alexcrichton
bors added a commit that referenced this pull request Jul 7, 2016
@bors bors merged commit 3f6c38c into rust-lang:master Jul 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants