Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a section about crate documentation. #34667

Merged
merged 1 commit into from
Jul 7, 2016
Merged

Add a section about crate documentation. #34667

merged 1 commit into from
Jul 7, 2016

Conversation

GuillaumeRochat
Copy link
Contributor

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@GuillaumeRochat GuillaumeRochat mentioned this pull request Jul 5, 2016
Closed
@GuillaumeRochat
Copy link
Contributor Author

r? @steveklabnik

@Manishearth
Copy link
Member

@bors r+ rollup

Thanks!

@bors
Copy link
Contributor

bors commented Jul 5, 2016

📌 Commit 159d1ab has been approved by Manishearth

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jul 5, 2016
@steveklabnik
Rollup merge of rust-lang#34667 - KaivoAnastetiks:fix/crate-documenta…
c0038f5 
…tion, r=Manishearth

Add a section about crate documentation.

Fixes rust-lang#34329
?r @steveklabnik
@steveklabnik steveklabnik mentioned this pull request Jul 5, 2016
Closed
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jul 5, 2016
@steveklabnik
Rollup merge of rust-lang#34667 - KaivoAnastetiks:fix/crate-documenta…
ef8ecf2 
…tion, r=Manishearth

Add a section about crate documentation.

Fixes rust-lang#34329
?r @steveklabnik
@steveklabnik steveklabnik mentioned this pull request Jul 5, 2016
Closed
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jul 6, 2016
@steveklabnik
Rollup merge of rust-lang#34667 - KaivoAnastetiks:fix/crate-documenta…
8c3efd2 
…tion, r=Manishearth

Add a section about crate documentation.

Fixes rust-lang#34329
?r @steveklabnik
@steveklabnik steveklabnik mentioned this pull request Jul 6, 2016
Merged
bors added a commit that referenced this pull request Jul 7, 2016
@bors
Auto merge of #34695 - steveklabnik:rollup, r=steveklabnik
5c674a1 
Rollup of 15 pull requests

- Successful merges: #33250, #33265, #34277, #34327, #34521, #34558, #34615, #34619, #34621, #34625, #34626, #34636, #34664, #34667, #34685
- Failed merges: #33951
@bors
Copy link
Contributor

bors commented Jul 7, 2016

☔ The latest upstream changes (presumably #34695) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors merged commit 159d1ab into rust-lang:master Jul 7, 2016
@GuillaumeRochat GuillaumeRochat deleted the fix/crate-documentation branch July 7, 2016 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GuillaumeRochat @rust-highfive @Manishearth @bors @steveklabnik