Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustbuild: can't remove dependency on FileCheck #35752

Closed
japaric opened this issue Aug 17, 2016 · 1 comment · Fixed by #36055
Closed

rustbuild: can't remove dependency on FileCheck #35752

japaric opened this issue Aug 17, 2016 · 1 comment · Fixed by #36055
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@japaric
Copy link
Member

japaric commented Aug 17, 2016

With the old build system, one can use the --disable-codegen-tests flag to disable the check for the existence of the FileCheck binary.. Passing this flag to rustbuild doesn't have the same effect; it still checks for the FileCheck binary.

cc @alexcrichton
@alexcrichton alexcrichton added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Aug 17, 2016
@alexcrichton
Copy link
Member

I believe the configure script has some variable for this, so should be easy enough to detect!

japaric pushed a commit to japaric/rust that referenced this issue Aug 27, 2016
rustbuild: skip filecheck check if codegen tests are disabled
c70d633 
to match the behavior of the old Makefile-based build system

closes rust-lang#35752
@japaric japaric mentioned this issue Aug 27, 2016
Merged
bors added a commit that referenced this issue Aug 28, 2016
@bors
Auto merge of #36055 - japaric:rustbuild-no-filecheck, r=alexcrichton
b17fa8b 
rustbuild: skip filecheck check if codegen tests are disabled

to match the behavior of the old Makefile-based build system

closes #35752

r? @alexcrichton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rustbuild: skip filecheck check if codegen tests are disabled japaric/rust
2 participants
@alexcrichton @japaric