Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustbuild: skip filecheck check if codegen tests are disabled #36055

Merged
merged 2 commits into from
Aug 28, 2016

Conversation

japaric
Copy link
Member

@japaric japaric commented Aug 27, 2016

to match the behavior of the old Makefile-based build system

closes #35752

r? @alexcrichton

to match the behavior of the old Makefile-based build system

closes rust-lang#35752
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

I think this may also want to disable the codegen tests as well? It's ok to just return early from that "step" in this case.

@japaric japaric force-pushed the rustbuild-no-filecheck branch from a484666 to c70d633 Compare August 28, 2016 03:12
@japaric
Copy link
Member Author

japaric commented Aug 28, 2016

It's ok to just return early from that "step" in this case.

@alexcrichton Does the last commit look OK?

@alexcrichton
Copy link
Member

@bors: r+ b8ebc13

@bors
Copy link
Contributor

bors commented Aug 28, 2016

⌛ Testing commit b8ebc13 with merge b17fa8b...

bors added a commit that referenced this pull request Aug 28, 2016
rustbuild: skip filecheck check if codegen tests are disabled

to match the behavior of the old Makefile-based build system

closes #35752

r? @alexcrichton
@bors bors merged commit b8ebc13 into rust-lang:master Aug 28, 2016
@japaric japaric deleted the rustbuild-no-filecheck branch August 29, 2016 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustbuild: can't remove dependency on FileCheck
4 participants