Skip to content

configure needs to detect name of the nodejs binary #36207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brson opened this issue Sep 2, 2016 · 3 comments
Closed

configure needs to detect name of the nodejs binary #36207

brson opened this issue Sep 2, 2016 · 3 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Sep 2, 2016 •
edited
Loading

On some systems it's nodejs, on some its node. It should probably just use "nodejs" unless "nodejs" doesn't exist and "node" does. Not having node shouldn't be an error. I don't recall exactly how the configure script handles these cases but there's existing code to crib off of.

Then bootstrap can pass that value to compiletest via command line, which uses it for running emscripten tests.
@brson brson added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-build labels Sep 2, 2016
@brson
Copy link
Contributor Author

brson commented Sep 2, 2016

cc #33205

@ducks ducks mentioned this issue Sep 4, 2016
Merged
bors added a commit that referenced this issue Sep 9, 2016
@bors
Auto merge of #36256 - rjgoldsborough:make-configure-detect-nodejs-36…
1284081 
…207, r=alexcrichton

adding a check to bootstrap script

and a check to the rust config script

refs #36207

first crack at making configure detect nodejs
@foophoof
Copy link

Is this solved now that #36256 is merged?

@alexcrichton
Copy link
Member

@foophoof indeed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexcrichton @brson @foophoof